Closed (fixed)
Project:
Mail Comment
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Oct 2010 at 13:03 UTC
Updated:
30 Aug 2013 at 14:51 UTC
I have experienced a serious problem in which a reply by me is posted on site under the wrong name. This is the sequence:
I create a new topic either by email (using a dedicated email address - not the mail comment address) or on-line.
A Notification of the new topic is sent out.
A different member comments on my topic by replying to the Notification.
His reply (comment) is posted on-line in the correct place demonstrating mail comment is doing its job.
A Notification of the new comment is sent out.
So far so good, but now the problem:
I reply by email to the comment my friend made. The comment is uploaded and put in the right place but it says it is from my friend!
Comments
Comment #1
Remon commentedAny updates on this issue?
Comment #2
ezra-g commentedWith the latest 2.x dev of Mailhandler and 6.x-2.2 of Mailcomment I'm having a similar issue: All comments are attributed to user 1 regardless of the author.
From some debugging, I found that the MailcommentAuthenticate class isn't being used to determine the author. My expectation was that this class would be used by mailcomment instead of MailhandlerAuthenticate, but I see that mailcomment_default.module also sets MailhandlerAuthenticate as the default authentication plugin in its featureized export.
MailcommentAuthenticate doesn't appear as an option at admin/build/feeds/edit/mailhandler_comments/settings/MailhandlerParser under the "Authentication plugin" dropdown, which leads me to wonder if it's being defined incorrectly in some way.
I'd love to file a patch to correct this. It would be great to get some confirmation that this is the right line of debugging. I'm in #drupal-contribute on IRC if you'd like to chat.
Comment #3
danepowell commentedJust FYI, 6.x-1.x is no loner maintained so I can't speak to the original issue.
As to #2- I'm not sure why the MailhandlerAuthenticate plugin isn't working, it should just key off of the sender's address. At any rate, I agree that it's a bug that the default importer uses MailhandlerAuthenticate, and I think you are on the right track overall.
Comment #4
danepowell commentedI changed the default authentication plugin to MailcommentAuthenticate.
http://drupalcode.org/project/mailcomment.git/commit/3ea7f89e493c9aec543...
http://drupalcode.org/project/mailcomment.git/commit/a9f101ac04277a998c6...