Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
filter.module
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 Oct 2010 at 19:59 UTC
Updated:
16 Aug 2013 at 11:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
webkenny commentedSetting to needs review for the bot.
Comment #3
webkenny commentedMy patching skills a little rusty these days apparently. Here's a clean one with the necessary re-roll to keep the array contents alpha sorted. The reason the last patch failed the test was my use of diff to create it. :)
Comment #4
moshe weitzman commentedComment #5
dries commentedCommitted to CVS HEAD. Thanks.
Comment #6
David_Rothstein commentedDoesn't this introduce an inconsistency with http://api.drupal.org/api/function/_filter_url/7, which uses the same variable? It seems like that one should be updated too...
(Maybe a separate followup issue; it really seems like this list should be stored in a single helper function rather than a couple different places. That would prevent it from easily getting out of sync like this.)
Comment #8
David_Rothstein commentedA few years later, the followup actually did happen :) #2026269: Different default values for filter_allowed_protocols variable
Comment #9
webkenny commentedWe really know how to make the words, "Never too late" mean something around here. :) Thanks for the post, David.