webform 6.x-3 support for signup_webform

subscribing. looking for some time for testing this one..

Wow very cool, and EXACTLY what I'm looking for right now.
But... don't actually know how to use it and what to do exactly?
Could you please write a real short tutorial, step-by-step what to do?
Where can I find the signup_webform module??
I have signup and webform installed, and attached a node-reference field to the signup-content where I can select a webform, right?
What file(s) do I need to patch? Do I need something else? How do I apply the functionality? Do I need something in template.php?

Thanx David,
After I've applied the patch I get the following Error message when trying to call the node for signup:

Fatal error: Call to undefined function drupal_get_installed_schema_version() in /var/www/virtual/XXXXX.de/htdocs/XXXXX/sites/all/modules/signup/modules/signup_webform/signup_webform.module on line 68

Hm... Yes, I tried flushing the cache before and called up update.php.
Right now I even deinstalled everything from the signup module and installed it again.
Everytime I try to configure the signup settings for a node it's the same error-message above...
by the way, I did't have the error before applying the patch ...but then fileuploads did't work.

are you sure that you are running Drupal 6.x?

well... yeah... I AM pretty shure, thanx.
6.19, and newest webform module, too.

Ok, many thanx! It works.
Here's a little bug:
If I go to "Edit webform components" from the signup, then I can select which field to add... if I submit it jumps right back to the signup-configuration page instead of adding a field and going on to the configuration of that field.

Filefields don't work either, do they? Simply nothing happens there, when I add a local file and submit the form. Form is submitted but no file is stored or sent.

If I combine several forms in one signup, the data is stored seperatly in every webform-results-table? So I can't see all Submissions of a combined signup and export them right?

If I use one form in multiple different signup nodes, all results run together in the same webform results?

Thanx macdee, good job anyway!
I also had the idea with views and the bonus pack, but the problem with using the same webform for different nodes still applies then... I can't figure out which entry is for which node... maybe with a "referer"-field...

According to the module itself: Would't it work fine if a copy of the chosen webform is generated (changing the name in "[webformname] - [node-title of signup-node]" evertime a webform is assigned to a node-signup?

Next Idea: Instead of the "Informations" for each signup in the signups overview then there could be a link to the webform result instead.

Just some ideas, and pretty much influenced about my current projekt issue ;-)
But anyway, this would be an awesome solution for signups.

+++ signup/modules/signup_webform/README.txt	2010-10-22 11:15:49.000000000 -0700
@@ -1,4 +1,4 @@
-$Id: README.txt,v 1.1.2.1 2010/10/18 21:42:11 joachim Exp $
+$Id$

Please don't include Id changes in patches; CVS takes care of this.

+++ signup/modules/signup_webform/signup_webform.info	2010-10-22 11:15:50.000000000 -0700
@@ -1,14 +1,7 @@
-; Information added by drupal.org packaging script on 2010-10-19
-version = "6.x-2.x-dev"
-core = "6.x"
-project = "signup"
-datestamp = "1287447546"

Ditto. You should be working from a CVS checkout and these lines should be absent from it anyway.

+++ signup/modules/signup_webform/signup_webform.install	2010-10-22 13:35:25.000000000 -0700
@@ -1,7 +1,8 @@
- * @file signup_webform.install
+ * @file
+ * Install file for signup_webform

Don't make unrelated changes please.

+++ signup/modules/signup_webform/signup_webform.install	2010-10-22 13:35:25.000000000 -0700
@@ -38,7 +39,7 @@ function signup_webform_schema() {
-  
+

... or alter whitespace ;)

+++ signup/modules/signup_webform/signup_webform.module	2010-10-26 01:26:15.000000000 -0700
@@ -40,33 +39,65 @@
+function signup_webform_webform3() {
+  // Check if this is Webform 6.3x
+  // Make sure the installation API is available before running drupal_get_installed_schema_version()
+  include_once './includes/install.inc';
+  return drupal_get_installed_schema_version('webform') > 6300 ? TRUE : FALSE;
+}

I don't see where this is called from or how it's used, but I don't see the point of it. Webform 3 is now the only supported version -- all we need to do is say in the documentation and the project page that you need Webform 3. End of story. At a push, we can stick a hook_requirements(), if we're really feeling nice.

This patch has now exceeded its kitten allowance. Could you tidy up and I'll try to find time to review it again?

Powered by Dreditor.

PS. Also, WTF?

+  return drupal_get_installed_schema_version('webform') > 6300 ? TRUE : FALSE;

You're testing for truth and THEN on the back of that returning TRUE or FALSE? You already have that!!!

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -100,7 +101,7 @@ function signup_webform_signup_pane_info
- *   If this is an existing signup, the fully loaded signup object. If this is a 
+ *   If this is an existing signup, the fully loaded signup object. If this is a

You're still making a load of spurious changes to whitespace.

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -111,41 +112,31 @@ function signup_webform_signup_pane_info
-  $webform_nid = substr($pane_id, 8);
+  $webform_nid = drupal_substr($pane_id, 8);

Given that pane ids are machine names, I doubt we need unicode support in dealing with them.

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -111,41 +112,31 @@ function signup_webform_signup_pane_info
+  // Add the signup sid to the form.
+  $form['details']['pane_id'] = array(
+    '#type' => 'hidden',
+    '#value' => $pane_id,

Comment and code do not agree.

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -155,69 +146,226 @@ function signup_webform_form(&$signup_fo
+      // Set a cookie including the server's submission time.
+      // The cookie expires in the length of the interval plus a day to compensate for different timezones.
+      if (variable_get('webform_use_cookies', 0)) {

What's this for? Is it cribbed from similar behaviour in webform?

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -155,69 +146,226 @@ function signup_webform_form(&$signup_fo
+    // Check if this form is sending an email.
+    if (!$is_draft && !$webform_data['details']['finished']) {
+      $submitted = webform_get_submission($webform_nid, $sid, TRUE);
+
+      // Create a themed message for mailing.

Do we really have to do all this? Does webform not have a function we can call? If not, and it does everything in the submit handler, then maybe consider submitting a patch to it?

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -275,14 +436,14 @@ function signup_webform_signup_form_data
@@ -292,36 +453,6 @@ function signup_webform_signup_form_data

@@ -292,36 +453,6 @@ function signup_webform_signup_form_data
     // as an additional field for the ['signup_log']['form_data'] field.
     $submission_sid = $form_data[$pane_id]['sid'];
     $submission = webform_get_submission($webform_nid, $submission_sid);
-    
-    // Check there is an actual submission: if no webform fields are compulsory,
-    // a user can sign up and not create a corresponding webform submission.

What are you doing for the form_data hook?

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -332,66 +463,27 @@ function signup_webform_signup_form_data
- * Implementation of hook_nodeapi().
- *
- * When a whole signup node is deleted, delete data related to it.

This too.

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -426,10 +518,53 @@ function signup_webform_form_node_delete
+    drupal_set_title(t('Unable to delete Submission #' . $submission_sid, array('%title' => $node->title)));

Call to t() is missing the token.

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -426,10 +518,53 @@ function signup_webform_form_node_delete
+ * Form validation function.

Move this so it's immediately after the form builder.

+++ signup/modules/signup_webform/signup_webform.module	2010-11-01 23:22:43.000000000 -0700
@@ -439,16 +574,21 @@ function signup_webform_get_signup_submi
+  * Errors are suppressed here because webform_get_submission() throws a SQL warning for previously signed up users
+  * of an existing signup if a new webform has just been added that didn't exist when they initially registered.
+  * Once the signup is re-saved thus including the new webform, the warning will no longer appear.

Are those more than 80 cols wide?

Also, nitpick, but it's 'an SQL', not 'a SQL'. ;)

Also, by 'a new webform added', do you mean created as a node, or added to the signup system? If the latter, then we should be able to act on its addition and fix our data. Suppressing errors doesn't seem like a good thing to me.

Powered by Dreditor.

> I merely addressed whitespace and formatting issues in the original that Coder was complaining about. Ditto with the string functions. I tried to revert as much as I could find back to what you previously had just to cheer you up.

Please read up about how best to make patches -- in particular, search for webchick's blog post about patches and kittens. In brief: a patch should address ONE thing only.

> As for the nitpick, I guess it's all in how you pronounce it. I pronounce it as 'sequel' not as individual letters.

Indeed, but Wikipedia seems to say the standard pronunciation is as initials ;)

sub

Any movement on this issue? I could use some webform v3 compatibility with signup 6.x-2.x-dev.

Patch needs work -- it's up to someone with the time to work on it.

subscribing

Hi

I installed signup and signup webform from the following location: https://github.com/joachim-n/signup which contains a singup_webform.module file form march 3, 2010.

I am a bit confused on which patch if any I should be using. Right now it isn't working, when I try to go to a page that has a signup with a webform, I get this message:

Fatal error: Call to undefined function webform_load_components() in C:\xampp\htdocs\drupal_6_2\sites\all\modules\joachim-n-signup-226fc7e\modules\signup_webform\signup_webform.module on line 124

Help appreciated

subscribe

Hi,
I'm interested in the signup_webform integration module including any patch necessary for adapting it to the most up-to-date version of webform (and signup) under Drupal 6. Maybe, it could also be useful for the signup rules integration module I'm working on (still a sandbox project).

Is there a reason that the signup_webform module is not available on drupal.org as a project? Now, that drupal.org has moved from cvs to git, I mean. Are there plans for an official module?
Thanks for any info,
Christian.

This module has great potential. The current reason why we are not using SignUp for events is because more than three fields of information are typically requested from people attending events. A signup_webforms module will be great by allowing the flexibility of webforms with the convenience of reminders etc.

+1 vote for a project

Interesting idea, i am agree with macdee, a separate module will be better and compatible with 6.x-1-x.dev of signup will be great :)

Just to be practical with respect to branching (1.x not 2.x), but also to go ahead & test even before commit, I'm re-rolling this patch against another patch here #1148552: Sync 6.x-2.x with 1.x/master. Reasons explained in #1 of that issue.

I made the following changes to this patch:
* replaced pane_id drupal_substr() instances with substr()
* changed sid comment to pane_id
* removed cookie stuff
* fixed missing token in t()
* moved signup_webform_form_validate() just below signup_webform_form()
* wrapped comments in signup_webform_get_signup_submission at 80 columns with //
* followed wikipedia about SQL pronunciation just for fun (a to an)
* I left the whitespace cleanup, because - why not.

@joachim I don't have answers to some of the other questions you raised about macdee's last patch. However, unless there's a solution, this is better to get working insist on perfection at this point. Maybe we'll even get this all in the 6.x-1.x version of Signup. That's be pretty sweet wouldn't it?

Typo in above patch. Also, fix the t() token to read as it should.

marking this as won't fix per #1148552: Sync 6.x-2.x with 1.x/master -It would be great to see this functionality made available as a separate project, and I'd be happy to improve the Signup API if necessary to help make this possible.