The README.txt file needs some cleanup to remove references to Drupal 5, provide a better explanation of what it does, etc.

CommentFileSizeAuthor
#9 nodewords-n945670-9.patch14.83 KBdamienmckenna
#7 nodewords-n945670-7.patch12.11 KBdamienmckenna
#6 nodewords-6x1x-945670.patch1.01 KBjessehs
#4 nodewords-n945670-d6_1.patch10.4 KBdamienmckenna
#4 nodewords-n945670-d6_2.patch9.98 KBdamienmckenna
#2 nodewords-n945670-2.patch4.48 KBdamienmckenna
#1 nodewords-n945670-readme.patch4.47 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new nodewords-n945670-readme.patch4.47 KB

Anyone want to take a look? Anything else that should be covered? Anything that could be cleaned up?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodewords-n945670-2.patch4.48 KB

Minor tweak, clarifying Dave Reid as being the maintainer and me as the co-maintainer.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Reviewed & tested by the community

This should be committed to both 1.x and 2.x branches. It's pretty rare that an update to README.txt is going to be a bad thing.

A followup issue (or if we want to continue it here): Most READMEs include information on how to actually use the module (such as where the configuration options live and how to set it up). Especially in the 2.x version, this would be invaluable information and should be in the README.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodewords-n945670-d6_2.patch9.98 KB
new nodewords-n945670-d6_1.patch10.4 KB

Updated patches for the v6.x-1.x and v6.x-2.x branches.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review
jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new nodewords-6x1x-945670.patch1.01 KB

I wanted to get a few inaccurate lines in the readme in the 1.x branch changed. Here's a patch against dev.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodewords-n945670-7.patch12.11 KB

I cleaned up a good chunk of the 6.x-1.x README.txt file, including the few items pointed out by jessehs in patch #6.

Status: Needs review » Needs work

The last submitted patch, nodewords-n945670-7.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new nodewords-n945670-9.patch14.83 KB

Updated patch, with a few extra tweaks.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)
Issue tags: -v6.x-1.12 blocker

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +v6.x-1.12 blocker

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.