Bakery reports the result of the profile synchronization to normal users, even if they don't need the information or have no way of understanding it. For example:

    Account not found on localize.drupal.org.
    Successfully updated account on Drupal API.
    Account not found on docs.drupal.org.
    Successfully updated account on groups.drupal.org.
    Successfully updated account on Drupal Association.
    Error 503 Service Unavailable for site at http://sf2010.drupal.org/
    Successfully updated account on DrupalCon Copenhagen August 23-27 2010.
    Successfully updated account on Security.
    Account not found on DrupalCon Chicago.

We should hide all those. There are of no use to users that don't have the 'administer users' permission.

CommentFileSizeAuthor
#6 946196_only_show_to_admins_log_always_6.patch1.93 KBcoltrane
#5 946196_only_show_to_admins_log_always_5.patch1.93 KBcoltrane
#4 946196_only_show_to_admins_log_always_3.patch1.92 KBcoltrane
#3 946196_only_show_to_admins_log_always_2.patch1.94 KBgreggles
#1 946196_only_show_to_admins_log_always.patch1.85 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new 946196_only_show_to_admins_log_always.patch1.85 KB

This is a usability improvement that we should definitely get done.

coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Needs work

This works well. Only issue stopping me from RTBC is:

+++ bakery.module	19 Oct 2010 20:41:11 -0000
@@ -125,16 +125,27 @@ function bakery_user($op, &$array, &$acc
+        $message = 'Error %error for site at %url';
...
+        watchdog('bakery', $result->data);

Shouldn't $result->data be filtered here as well?

Powered by Dreditor.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 946196_only_show_to_admins_log_always_2.patch1.94 KB

Fair enough :)

coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 946196_only_show_to_admins_log_always_3.patch1.92 KB

filter_xss() does a lot of string manipulation so its a minuscule improvement to use it once. Also adding some more comments.

coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 946196_only_show_to_admins_log_always_5.patch1.93 KB

#4 doesn't contain the message in the dsm, oops. Try this instead.

coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 946196_only_show_to_admins_log_always_6.patch1.93 KB

Argh, extraneous // TODO rollback comment in the successful slave update logic

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Priority: Critical » Normal
Status: Needs review » Patch (to be ported)

Great, now committed - http://drupal.org/cvs?commit=438772

Thanks, Coltrane!

toemaz’s picture

toemaz commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Needs work

I was confused reading that the patch was committed and yet, I couldn't see the code in the module. And indeed, this patch was reverted in commit #442648. Is there any chance this patch can be committed again?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Patch (to be ported)

I believe this has been committed to 6.x-2.x.

6.x-1.x-dev is not really maintained any more, so I think the last place for this is in 7.x-1.x-dev.

fuzzy76’s picture

fuzzy76 commented
Version: 7.x-1.x-dev » 7.x-3.x-dev
Issue summary: View changes

How's the status for this? D.O doesn't do this, but our 7.x-2.0-alpha4 install does.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented

I'm not sure what's happened in the meantime, but this is definitely still happening on d.o (I posted an issue about it at #2409307: Clean up confusing notifications when updating profile). Would be nice to see this finally pulled into the 7.x branch.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Patch (to be ported) » Closed (duplicate)

The 7.x patch landed at #2323705: Add user's organization computed reference field, which we now patch on Drupal.org.

drumm’s picture

drumm
he/him
Location NY, US
commented

Correct issue: #1361548: Change status drupal_set_messages to users with administer bakery.