notnull should be not null [#946618]

In both the stable and developmental version the dashboard install script has

        'col' => array(
          'type' => 'int',
          'size' => 'tiny',
          'unsigned' => TRUE,
          'notnull' => TRUE,
        ),

Instead of:

        'col' => array(
          'type' => 'int',
          'size' => 'tiny',
          'unsigned' => TRUE,
          'not null' => TRUE,
        ),

for the dashboard_widget table

This causes problems for databases where the default is not null when this is not specified such as:
Query failed: ERROR: null value in column "conf" violates not-null constraint in ..

Comments

Comment #1

verta commented 14 March 2011 at 15:34

Just installed and enabled Dashboard 6.x-2.1 on Drupal 6.20 and got a

user warning:

Field 'conf' doesn't have a default value query: INSERT INTO dashboard_default (id, title,description,thumbnail,tags,default_enabled,widget_type,subtype) VALUES ('1','Recent Comments Block', 'Recent Comments.', '0','comments','1','block','comment-0') in dashboard.install on line 14.

on the next screen.

Related? Or should I open a new issue?

Comment #2

verta commented 14 March 2011 at 15:40

The block above the one discussed in #1 (field 'col') is field 'conf' and it has the same issue.

        'conf' => array(
          'type' => 'blob',
          'notnull' => FALSE,
          'size' => 'big',

Comment #3

verta commented 14 March 2011 at 15:47

Another data point for you, that really should be a separate issue, but I'm just going to note them here, the engine type on the tables is InnoDB, while my database default is MyISAM. Not sure if that's important to this thread, but thought I would mention it.