_quicktabs_get_active_tab() checks to see if default_tab is set, but doesn't explicitly check to see if it's set to false. This means that occasionally you get strange behaviour, especially when embedding quicktabs within other quicktabs.

CommentFileSizeAuthor
#3 946620.3-fix-active-tab-logic.patch1.1 KBdeviantintegral
get_active_tab.patch784 bytesroblinton

Comments

katbailey’s picture

katbailey commented
Status: Active » Fixed

Wow - I committed this fix back in October but somehow never updated the issue. Lameness.
http://drupalcode.org/project/quicktabs.git/commitdiff/8c110db18f3d9bd64...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

deviantintegral’s picture

deviantintegral commented
Version: 6.x-3.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Reviewed & tested by the community
StatusFileSize
new 946620.3-fix-active-tab-logic.patch1.1 KB

Any chance this could be applied to the 6.x-2.x branch as well? Here's a rerolled patch with the same code from 6.x-3.x.

katbailey’s picture

katbailey commented
Status: Reviewed & tested by the community » Fixed

How could I refuse when you made it so easy ;-)
http://drupalcode.org/project/quicktabs.git/commitdiff/15f3e1f5ca23a2c42...

deviantintegral’s picture

deviantintegral commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.