Nodes with new comments are announced as "new posts"

Please try the current dev version, this issue should be resolved there.

current -dev also still have this problem. as state it, it confused between new node and new comments.

argh.. found the problem.

at line 547,

$node = $node[$nid];

it supposed to be:

$node = $nodes[$nid];

the string should be $nodes not $node which cause the error shown. $node is reserve for drupal variable. while in this module, $nodes refer to the array. it fixed at my site.

subscribing

@parasolx, I'm not a module maintainer but really appreciate your work

comment #5 is very helpful, but I think it should actually be posted in the other issue http://drupal.org/node/935458 because it is a refinement of the patch in comment #1 of that issue.

In fact it might be best to create a new patch in that issue with this fix.

This issue might then be marked as a duplicate while work continues in the other issue queue.

Thank you

@izmeez, i also not this module maintainer. this is a really big problem.

actually there are a lot of patch that have been produced but never being committed into community. last -dev version was committed on Feb 2011, almost 7 month without any new code applied.

i will contact the maintainer so that we can work out again about all patches.

regarding this issues, i will re-post this solution there.

@parasolx, thanks for posting the solution in the other queue.

ON closer reading of this issue I don't think it is a duplicate of the other issue as this one is describing a problem with the content of the email being sent. I'll watch for further comments on this issue.

I norder to make progress on this, we need to clearly document:

1. The steps necessary to reproduce on a new Drupal install.
2. The expected results.
3. The actual results and how they differ from the expectation.

I am unable to reproduce this.

Steps:

1. Installed Drupal 6.26 and Notify 6.x-1.2.
2. Set up notifications to be sent every 15 minutes. Enabled notifications for Story.
3. Created users "adam", "bevis" and "charles".
4. Granted all users permissions to create content and to comment.
5. Enabled Notify new content and Notify new comments for user "bevis"
6. User "adam" created a Story.
7. Waited for notification to be sent.
8. User "charles" added a comment to the node.
9. Waited for notification to be sent.

Body of the last notification email (step 9) is reproduced below. I think Notify behaves is as expected. (I.e. there is no notification of a new node, just of the comment.)

Greetings bevis,

------------------------------------------------------------------------------
Recent comments - 1 new comment
------------------------------------------------------------------------------

1 new comment attached to Story posted by adam: Story by adam
    1. This is a comment by charles
      http ://diw.ifi.uio.no/gruppe03/node/1#comment-3


--
This is an automatic e-mail from Drupal 6 test.
To stop receiving these e-mails, change your notification preferences at  
http://diw.ifi.uio.no/gruppe03/user/4/notify

(I've inserted a space after "http" to stop Drupal from turning it into a link.)

TfR75, could you be so kind and check again if this is reproducible?

And if anyone else could check to see if this issue or reproducible or not, it will be appreciated.

However, I've noticed that nodes with updated content is announced as "new posts". Is this what you're experiencing?

@gisle we are seeing similar results and do not seem to have a problem.

See comment #14 and #15.

Update: This bug was never in Notify 6.x-1.2. It was introduced in the patch attached to comment #1 in #935458: $nodes array modified inappropriately by comment notification logic in _notify_send() and made it into commit 5ec7f53 in 6.x-1.x-dev (committed on Oct. 8 2010).

The problem, and its solution, is in comment #9 under the same issue, and comment #5 in this issue.

There has obviously been some confusion about versions here, and I accept my share of blame for this.

As of this morning, the correction has been applied to the 6.x-1.x-dev developmen snapshot.

Since the bug was introduced in patch that was applied after the release of 6.x-1.2, it does not apply to that particular version.

Several issues report some similar problem. Here is the list:

• #111762: Multiple notifications sent
• #180052: Allow throttling of mails to prevent cron timeout
• #365700: Need to queue mailings across multiple cron runs for scalability
• #368175: Race condition in notification
• #538306: repeat notifications
• #935458: $nodes array modified inappropriately by comment notification logic in _notify_send()
• #947264: Nodes with new comments are announced as "new posts" (this)
• #1336084: Groundhog day: Repeat notifications when notify_cron() times out during _notify_send().

This really is a duplicate of #935458: $nodes array modified inappropriately by comment notification logic in _notify_send(), so I'm changing status.

@gisle, thanks for taking care of this. We were using 6.x-1.2 with a series of patches in our make file so did not encounter this.