$form['flag_action']['warning'] uses #value, but it should use #markup. I'm not fixing this myself because I'm not sure this file was ported to D7 at all (my memory of Actions is rusty so I don't quite know how to trigger the code there).

CommentFileSizeAuthor
#5 trigger7.diff7.29 KBmooffie

Comments

mooffie’s picture

mooffie commented
Title: About 'flag.actions.inc' ... » D7: Make Actions/Trigger work

I'll assume this part of Flag wasn't yet ported to D7.

mooffie’s picture

mooffie commented

#956096: _trigger_get_hook_aids() does not exist in Drupal 7 was marked a dup of this issue.

mooffie’s picture

mooffie commented

A patch for a D6 issue, #873464: Triggered actions don't work, should be applied to D7 as well, after porting.

mooffie’s picture

mooffie commented

Fixed a minor constant bug.
http://drupal.org/cvs?commit=454682
(But why does this function return a value? It isn't used, and it isn't in our D6.)

mooffie’s picture

mooffie commented
Status: Active » Needs review
StatusFileSize
new trigger7.diff7.29 KB

This is the patch I'm going to commit.

It has two parts:

- 'flag.actions.inc' was ported to D7.

- We had faulty code, in flag_flag(), that triggers our events. The patch from #873464: Triggered actions don't work was ported to D7.

mooffie’s picture

mooffie commented

Committed.
http://drupal.org/cvs?commit=455140
http://drupal.org/cvs?commit=455142

(Why two commits? I was inside the "includes" folder when I issued the first "cvs commit" command. I forgot CVS, unlike GIT, doesn't commit the changes above the currect folder.)

mooffie’s picture

mooffie commented
Status: Needs review » Fixed

Note that the event names are 'flag_flag' and 'flag_unflag'. I'd prefer them to be 'flag_flagged' and 'flag_unflagged', like I did for Rules. But I don't do this because, Nate, I see you prefer to use 'flag'/'unflag' for events, instead of the passive English verb.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.