I am getting the following (repeating) errors (noticed in version 6.x-3.3 already):

warning: array_slice() [function.array-slice]: The first argument should be an array in .../webform/webform.module on line 2407.
warning: implode() [function.implode]: Bad arguments. in .../webform/webform.module on line 2407.

I don't know the reason (empty fields, or something from the past...), but in any case these errors are generated when $element['#parents'] in theme_webform_element_wrapper() doesn't exist (is empty).

I've temporary resolved this issue adding is_array() check (shouldn't hurt being there in any case); instead of:

$parents = str_replace('_', '-', implode('--', array_slice($element['#parents'], 1)));

my line 2407 looks like this now:

$parents = str_replace('_', '-', implode('--', array_slice(is_array($element['#parents']) ? $element['#parents'] : (array) $element['#parents'], 1)));
CommentFileSizeAuthor
#36 webform_mime_mail_warning.patch1.12 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented

Weird, I wonder what elements don't have any #parents. All form elements should, otherwise they wouldn't have a "name" attribute either (since "name" is generated from #parents). Could you try to figure out which element doesn't have parents? It may be caused by another module (or your theme) modifying the form.

calbert’s picture

calbert commented

I am getting this error

* warning: array_slice() [function.array-slice]: The first argument should be an array in /var/www/vhosts/metrosource/drupal-6.16/htdocs/sites/all/modules/webform/webform.module on line 2407.
* warning: implode() [function.implode]: Bad arguments. in /var/www/vhosts/metrosource/drupal-6.16/htdocs/sites/all/modules/webform/webform.module on line 2407.

luti’s picture

luti commented

It's weird. When I display the form, all elements do have a #parent value.

When I submit the form, it seems to be processed twice. First, in more or less reverse order (last field on the form is processed first, but the rest is not exactly reverse - maybe as last time edited or so?), and all fields do not have a #parent here. After, fields seems to be processed in weight order (as displayed), and they do have a #parent here.

The majority of values seems to be the same both times. Some values:
- element['#id'],
- element['#parents'],
- element['#webform_validated'],
- element['#validated']
seems to be initialized later (present only in second processing).

Does it help?

BTW - the errors reported in #2 are exactly the same as mine, but in my case (11 form elements) everything is repeated 11 times after the form is submitted (message displayed on the confirmation page).

BBaptiste’s picture

BBaptiste commented

Hi.
I've the same error.
I use Drupal 6.19 + Webform 6.x-3.4 + Mime Mail 6.x-1.0-alpha6.
When I tick the webform parameter Email "Format: HTML" the error occurs, but if tick webform parameter Email "Format: Plain Text" I've no error.
I think this error may be caused by Mime Mail module ?

Have a good day !

Jerome F’s picture

Jerome F commented

Hi, same error here.
I use the same module versions.

quicksketch’s picture

quicksketch
he/him
commented

Hm, so a lot of people are having the problem. Can anyone describe how to reproduce this from a fresh install? I also have MIME Mail installed (though the dev version, not alpha6) and I'm not seeing these errors.

luti’s picture

luti commented

Have you tried to send webform messages as HTML (so they go through MIMEmail)? It might be that something is processed twice, as such mails do have a plain text and an HTML part...?

In any case, my patch from initial post seems to resolve the problem for me, so for the moment I don't care much about how it comes to the first form processing (it is the first time that values are not initialized, and second time there are values properly set...).

sigol’s picture

sigol commented

Agree - getting the same error.

However, switch off HTML submission and it works perfectly.

sigol’s picture

sigol commented

... sorry, pressed "Save" too early on my last post!

Can also confirm that your patch works perfectly. Thanks so much for this.

mellenger’s picture

mellenger commented

This patch just worked for me too. I have Mime Mail installed and am using HTML to send the webform email. Webform worked fine before i switched to HTML.

sgabe’s picture

sgabe commented

Same issue here, after updating to 3.4 release. LUTi's patch works, though would be better to know what is causing this.

luti’s picture

luti commented

Agree 100%.

But, for the moment, it is the most important for me that I am not getting a bunch of those errors all the time. I've tried to see how it comes to that, but I simply don't know enough about that all, unfortunately. Probably the authors (maintainers) should know more, how (when) this function can be triggered...

RedTop’s picture

RedTop commented

Same issue here, Drupal 6.19, webform 3.4, Mime Mail 6.x-1.0-alpha6.

bomarmonk’s picture

bomarmonk commented

Yes, same issue here. Subscribing.

Nexus’s picture

Nexus commented

I have the same issue. Using Drupal 6.17, webform 3.4, Mime Mail 6.x-1.0-alpha6. It gives me the following:

    * warning: array_slice() expects parameter 1 to be array, null given in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: implode() [function.implode]: Invalid arguments passed in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: array_slice() expects parameter 1 to be array, null given in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: implode() [function.implode]: Invalid arguments passed in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: array_slice() expects parameter 1 to be array, null given in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: implode() [function.implode]: Invalid arguments passed in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: array_slice() expects parameter 1 to be array, null given in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: implode() [function.implode]: Invalid arguments passed in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: array_slice() expects parameter 1 to be array, null given in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: implode() [function.implode]: Invalid arguments passed in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: array_slice() expects parameter 1 to be array, null given in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
    * warning: implode() [function.implode]: Invalid arguments passed in /home/yewchile/public_html/sites/all/modules/webform/webform.module on line 2407.
bomarmonk’s picture

bomarmonk commented

I tried Luti's fix at the top of the thread and it seemed to work.

inductor’s picture

inductor commented

The same issue, webform + mimemail. Subscribing.

Nexus’s picture

Nexus commented

There is no such line
$parents = str_replace('_', '-', implode('--', array_slice($element['#parents'], 1)));
in webform.module. Where did you find it ?

bomarmonk’s picture

bomarmonk commented

I replaced line 2407, as indicated at the top of this thread. It definitely looked just like the line you have copied here, Nexus.

Nexus’s picture

Nexus commented

I downloaded the last version of Webform and this is how my lines look like in webform.module:

2406  // Restrict replacements for anonymous users. Not all tokens can be used
2407  // because they may expose session or other private data to other users when
2408  // anonymous page caching is enabled.
2409  if ($user->uid || $allow_anonymous) {
2410    $safe_replacements += $replacements['unsafe'];

I also searched for this line:

$parents = str_replace('_', '-', implode('--', array_slice($element['#parents'], 1)));

but it doesn't exist in the file.

bomarmonk’s picture

bomarmonk commented

Are you using a development version?

Nexus’s picture

Nexus commented

Just the recommended Release Version 6.x-3.4 Date 2010-Oct-20

vikramy’s picture

vikramy commented

Subscribing..

luti’s picture

luti commented

Nexus,

in (my) version 3.4 (webform module, v 1.196.2.68 2010/10/18 07:38:44), these lines are starting at 2640. I'd suggest you to check again what do you have installed (line 2 of webform.module).

Nexus’s picture

Nexus commented

Hey LUTi, found it. The fix it's working fine, thanks !

mattcasey’s picture

mattcasey commented

Thanks, LUTi—I have this issue too and glad someone posted a fix. I've tried to figure out what's going on but have nothing extra to offer. Using Drupal 6.19 MIME Mail 6.x-1.0-alpha6, Webform 6.x-3.4

torpy’s picture

torpy commented

Subscribing!

webdrips’s picture

webdrips commented

Subscribe

webdrips’s picture

webdrips commented

The one detail I may add is this error may have been triggered by the form user entering a single quote in one of the fields. I essentially received a set of errors when a single quote is in one of the fields, but the submission works perfectly without the single quote.

I too am using Drupal 6.19, Webform 6.x-3.4, and MIME Mail 6.x-1.0-alpha6.

quicksketch’s picture

quicksketch
he/him
commented

Thanks daneesia.

More than anything else, I need step-by-step instructions to reproduce the problem, so far I'm still not sure what's causing the problem.

anrikun’s picture

anrikun commented

My steps to reproduce the bug:
1. Install and enable Mime Mail 6.x-1.0-alpha6
2. Create a webform with a field
3. Add an "E-mail to" and check "Send e-mail as HTML"
4. Try to submit the webform

anrikun’s picture

anrikun commented

theme_webform_element_wrapper is then called twice for each element.
The first time it is called, there is no #parents key.
That's why it displays a warning.

TimelessDomain’s picture

TimelessDomain commented

Just has this error from the following settings:
Mimemail - checked - Use mime mail for all messages (Mime Mail 6.x-1.0-alpha6)
Webform - checked - Send e-mail as HTML (Webform 6.x-3.4)

fixed it by
Unchecking Webform Send e-mail as HTML

nonzod’s picture

nonzod commented
Priority: Normal » Major
Issue tags: +webform

Same problem
Drupal 6.19
Webform 6.x-3.4
MimeMail 6.x-1.0-alpha6

* warning: array_slice() [function.array-slice]: The first argument should be an array in /var/www/httpdocs/sites/all/modules/webform/webform.module on line 2407.
* warning: implode() [function.implode]: Bad arguments. in /var/www/httpdocs/sites/all/modules/webform/webform.module on line 2407.

I want to send HTML email.

sylvaticus’s picture

sylvaticus commented

subscribing!

quicksketch’s picture

quicksketch
he/him
commented
Title: Argument not array error in webform.module » Argument not array error in webform.module when using MIME Mail
Priority: Major » Normal
Status: Active » Fixed
StatusFileSize
new webform_mime_mail_warning.patch1.12 KB

I've committed this patch which fixes the problem with the warnings. As it turns out, the warnings thrown by PHP have no actual effect on either the sending of e-mails or display unless your CSS targets individual items by ID.

anrikun’s picture

anrikun commented

Wouldn't it be better to simply skip the process when #parents is not set (the first time theme_webform_element_wrapper is called)?

quicksketch’s picture

quicksketch
he/him
commented

@anrikun: Not sure I follow you. The #parents array is still necessary to properly generate the class and ID of the component when sending the e-mail. This makes it so that CSS can target the element in the same way regardless of whether the component is being shown when viewing the submission on the website or when sending an HTML e-mail.

anrikun’s picture

anrikun commented

I meant:
theme_webform_element_wrapper is called twice (see #3, #31, #32) after form submit.
The warnings occur at first call, when #parents key is not defined yet.
But this first call has no use, it's the second one that is important.
So testing if #parents key exists and simply returning if not could do the trick, couldn't it?

quicksketch’s picture

quicksketch
he/him
commented

The first time (when the warning occur) are when the %email[key] tokens are generated. If we didn't provide #parents for that call, then the %email[key] tokens would be missing the classes array.

anrikun’s picture

anrikun commented

All right, I had missed that point. Thanks for the info.

beyond67’s picture

beyond67 commented

Has this been fixed in the latest 3.5 version?

quicksketch’s picture

quicksketch
he/him
commented

Has this been fixed in the latest 3.5 version?

No, the 3.5 version was an out-of-release security-only update, meaning it is exactly the 3.4 version with nothing but the security flaw corrected. I'm still planning on making new releases of the module with the next week (3.6 now) that will include the fix from this issue.

Status: Fixed » Closed (fixed)
Issue tags: -webform

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +webform

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.