CVS edit link for abarmot

I want to contribute my module «Profile Edit Default Tab».
Using Profile and Content Profile modules we can create user information categories which are displayed as tabs on user's account edit page. Currently there is no way to define default category tab. This feature is asked-for and can be provided only by writing custom code. «Profile Edit Tab Module» fixes this problem and adding functionality to define default tab.

Currently module is written and documented conforming Drupal coding standards, tested and working fine with categories provided by Profile and Content Profile modules. I think that «Profile Edit Tab Module» should be independent project because it provides additional features at least for 2 different modules.

I understand all the responsibility and promise to be a good maintainer.
Thanks.

Comments

danylevskyi’s picture

Title: abarmot [abarmot] » abarmot [abarmot] attachments
StatusFileSize
new18.48 KB
new30 KB

All documentation can be found in tarball.

danylevskyi’s picture

StatusFileSize
new9.55 KB

Sorry, broken tarball.
Attaching again.

danylevskyi’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new9.54 KB

Fixed minor warnings by Coder module.

avpaderno’s picture

Title: abarmot [abarmot] attachments » abarmot [abarmot]
Issue tags: +Module review

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

Scyther’s picture

Status: Needs review » Needs work

Remove the LICENSE.txt. CVS will add it for you.

Tested out the module and found a bugg. What I did was:

  • Added a new Profile Category "Test"
  • Set "Test" category to the default tab (and it worked)
  • Deleted the Profile Category "Test"
  • Clicked on edit under My account
  • Then I was sent to the "Test" profile category that didn't exists anymore.

Otherwise the code looks good and seems to follow coding standars.

danylevskyi’s picture

Status: Needs work » Needs review
StatusFileSize
new4.06 KB

Scyther, thank you for testing the module and bug report!
Today I added a code to check the presence of a category on user's account edit page.
Fixed module in attachment.

Scyther’s picture

Status: Needs review » Reviewed & tested by the community

Looks good and works.

danylevskyi’s picture

New version of the module in attachment.
Removed the support of Content Profile module. (Probably will be implemented in future versions).
Configuration page moved to new tab in the profiles list page. See screen shot please.

michelle’s picture

Status: Reviewed & tested by the community » Fixed

Approved based on Scyther's work.

Michelle

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.