Some PHP setups return $_SERVER['HTTP_HOST'] with a port designation -- e.g. http://domain.tld:80. With this patch, statistics.module removes the port designation before distinguishing between internal and external referrers. Without this patch, all referrers will be labeled as external in PHP setups where the port designation is included in HTTP_HOST.

CommentFileSizeAuthor
#5 parse_url.diff1.7 KBrobin monks
#3 incorrect.external.fix.patch1.73 KBrobin monks
statistics.http_host.patch2.34 KBnjivy

Comments

Anonymous’s picture

(not verified) commented

I have provided a patch before which also enabled stats module to treat more domain names as local ones, since a site might be accessible via multiple domain names (like www.drupal.org and drupal.org). That was not accepted. It is not just port numbers that are problems.

killes@www.drop.org’s picture

killes@www.drop.org commented

Doesn't apply anymore-

robin monks’s picture

robin monks commented
Assigned: njivy » robin monks
StatusFileSize
new incorrect.external.fix.patch1.73 KB

Updated patch to work with latest HEAD.

Tested to work with CVS HEAD.

I'll take over any further problems that this patch may incur.

Robin

dries’s picture

dries commented

Not sure but it might be shorter/better to use PHP's parse_url()?

robin monks’s picture

robin monks commented
StatusFileSize
new parse_url.diff1.7 KB

Here is a patch using parse_url.

Robin

robin monks’s picture

robin monks commented
Status: Needs review » Closed (duplicate)

A newer incarnaton of this code now rests with http://drupal.org/node/27787.

If that patch does not go though, this bug will be reopened and updated. Otherwise....duplicate.

Robin