Right now, when you first install Drupal, out of the box it shows a blank white page with a vertical scrollbar and no footer, which looks pretty silly since the page is totally empty:

If we reduce the min-height attribute from 500px to 325px then it looks like this, which IMO is much better, and doesn't have vertical scrolling.

However, I'm not a designer nor a CSS guru, so would love review on this change.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | bartik-min-width-height.patch | 651 bytes | Jeff Burnz |
| #8 | bartik-min-width-height.patch | 651 bytes | Jeff Burnz |
| #6 | pic1.jpg | 108.15 KB | dcrocks |
| #6 | pic2.jpg | 153.83 KB | dcrocks |
| drupal-bartik-min-height.patch | 485 bytes | webchick |
Comments
Comment #1
webchickComment #2
Jeff Burnz commentedOK, but what I really would prefer to do is change to a sticky footer, if that is possible in the time frame - the reason for this is #937602: Ugly black header background when horizontally scrolling, so it would actually solve both issues quite nicely.
I think we should seriously entertain the sticky footer concept again, we talked a lot about it in the past and even wrote some patches that did work quite well. Lets give it a crack.
Comment #3
webchickHm. That sounds like a pretty major visual and behaviour change from what it is currently, if I'm picturing what you're suggesting correctly. Basically, it'd make the top part of the theme look like it's in a frame?
If so, not sure we can still do that in D7. :\ Though it'd be nice to see #937602: Ugly black header background when horizontally scrolling polished off, too.
But if I'm wrong, then let's get a patch going ASAP. I haven't seen many new critical bugs pouring in since beta2, which means rc and release is coming up soon.
Comment #4
tim.plunkett#888412: Make footer stick to the bottom of the page was where we originally tried to address this.
bleen pointed out (http://drupal.org/node/888412#comment-3356012) a lot of ways for a sticky footer to go wrong. I think it would be great to get it working, but I'm not sure how feasible that is in the given time.
Comment #5
Jeff Burnz commented@webchick - no it wouldn't be like a frame, it would work like this: when the page content is shorter than the height of the browser the footer sits on the bottom, however, pages with content push the footer down like any normal page - you can see an example here: http://ryanfait.com/sticky-footer/
@tim - most of that is discussion regarding a JS sticky footer, which is quite hard to make work in a generic theme (without massive engineering, I mean I have scripts that are just monsters for doing JS sticky footers), however that's not what I am thinking here.
Lets just scope this out a bit:
1) A sticky footer could be a solution, if we can make it work, I know I have the CSS skills to pull it off - but I/we don't have very much time.
2) Possible better solution is forcing the footer to expand to fill the rest of the page and setting a very low min-height (maybe not at all), I really dislike the min height because we never know the height of the view port (think mobile, could be very small). It may look like that's how it works now, however it does not, its merely a visual trick that has the drawback of the issues in #937602.
If we decided to live with the issues in #937602 then we could, feasibly, simply remove the min-height and this issue is indeed a quickfix.
Comment #6
dcrocks commentedGetting the screen shown at the top is also a factor of screen real estate, I never came across it on my 20" monitor. Content will normally determine height, but to keep it from being too small a min-height of 325px could be set on #content rather than #main-wrapper. I was also able to get rid of the ugly black with some changes to layout.css and colors.css. I don't think I know this stuff well enough to generate a patch, but here is what I did:
In layout.css I
gave #main-wrapper a width of 960px
gave #page-wrapper and # header a min-width of 960px
changed the min-width setting to 325px for #content instead of #main-wrapper
In colors.css I gave #main-wrapper a background color of #ffffff
The 1st attached image shows bartik with horizontal scroll bar all the way to the right and the 2nd shows bartik with no horizontal scroll bar.
Comment #7
dcrocks commentedActually I didn't need to do anything to #main-wrapper. Giving min-width to #page-wrapper and #header were enough.
Comment #8
Jeff Burnz commentedSome good lateral thinking dcrocks, lets give that a go and at least test it out. No great support for IE6 but not exactly broken either.
Comment #9
dcrocks commentedI don't have anything to test IE6 but it looks to me like the min-height on main-wrapper should be a little larger. On a vanilla out-of-the-box drupal the 1st side bar is a little taller on the front page than on internal pages, causing the screen to 'jump' after logging in.
Comment #10
Jeff Burnz commentedWell it was just an arbitrary number so 300 seems as good as 265. We could add a height for IE6 actually, it treats height like min-height. Lets test with this, if its deemed appropriate we can add in the height for IE6, but as for min-width - supporting this is IE6 requires some hoop jumping with CSS and frankly I think its all a bit late for that (would need some serious testing as it can require floats, negative margins etc etc to emulate real min-width).
Comment #11
dcrocks commentedI should think these things through. I have my browsers default font size set to 18px, which of course effects the height of the sidebar. Still, in general their are problems with bartik elements at larger font sizes. Input boxes tend to to be too large for the containing area and conceptual link hover icons can overlap the search box. I think the current compromise should be designed for a larger font size.
Comment #12
Jeff Burnz commentedWell, at 300px the breadcrumb can appear and still not affect the min-height on a standard install, for the few pages that are available outside the overlay. I hear you on these other issues, problem is we don't have enough people posting issues and patches to help fix them, its tough enough just fixing the really critical issues - I'm struggling the get reviews for some really fundamental patches as it is. Patches and reviews welcome :)
Comment #13
dcrocks commentedI tried it in safari 5, opera 10.6, chrome, and ie8 and it seems to be fine. On my wife's little 9" netbook, scrolling is a way of life. To me, a sticky footer in bartik is kind of tall and I'd rather not have it on short browser windows.
Comment #14
dcrocks commentedps. #footer width set in 2 different places to 2 different values: Lines #11 and #92 in layout.css.
Comment #15
Jeff Burnz commented@14, its deliberate, we want #footer to get the margin values from the first declaration, rather than having to re-declare the auto margins just for #footer.
Comment #16
tim.plunkettThis will eventually be obsoleted by #888412: Make footer stick to the bottom of the page. jensimmons and I both like this. Good compromise.
Comment #17
webchickOk great. Committed to HEAD!