I have fixed the implementation of the ris import using the node form ( prepopulate ). Patch attached. i also fixed up the labels strings to be more user friendly ( of ris ).
- fixed missing require to export.import.inc
- fixed exporting to file ( importing from there )
- hard-redirect to edit for after the node gets saved ( so it looks like prepopulating )

Patched against

version = "6.x-2.x-dev"
core = "6.x"
project = "biblio"
datestamp = "1287533004"

CommentFileSizeAuthor
#17 biblio_pasting.patch3.22 KBtrigun
biblio_ris_import_fix.patch3.03 KBeugenmayer

Comments

rjerome’s picture

rjerome commented
Status: Reviewed & tested by the community » Fixed

While that was an interesting idea (writing out a temp file and re-importing it) I choose to refactor the code to allow parsing of a string containing RIS record and then prepopulating the input form with that data. This is more consistent with the way the other pre-populate methods work.

http://drupal.org/cvs?commit=444714

Ron.

eugenmayer’s picture

eugenmayer commented

Well your approach is the more clean one, but your the author, iam not even sure about the whole architecture, i was just qucikfixing it.

Anyway thansk

rjerome’s picture

rjerome commented

Don't get me wrong, I wasn't criticizing your efforts, just explaining why I choose to do it differently.

I appreciate any and all suggestions and patches.

Ron.

eugenmayer’s picture

eugenmayer commented

No worries.

Actually i ran into a bug and iam not sure were it comes from. The input of a RIS import is limited to 2048 in my implementation ( or generally ). Do you have an idea if your fix is already affected by this?

rjerome’s picture

rjerome commented

If you look at line 50 of the biblio_ris.module file, you will see where that limitation is being imposed. Just remove that line and you should be good to go.

eugenmayer’s picture

eugenmayer commented

Is this by intention or do we need a fix for this? My customer told me that this limitation is kind of useless, as if you have abstracts this boundary will be hit like in no time.

Any reasons to have it in there? Thanks

rjerome’s picture

rjerome commented

No there is no reason, it was probably just a cut'n'paste carry over :-(

It will be gone in the next release.

Ron.

eugenmayer’s picture

eugenmayer commented

is there a CVS branch where i can already can get the package, or are you interested in make dev snapshots? Would be kind of handy

thanks

rjerome’s picture

rjerome commented

The -dev snapshots get produced automatically every twelve hours (I have no control over this).

You can also find the RIS module code here http://drupalcode.org/viewvc/drupal/contributions/modules/biblio/modules...

Ron.

eugenmayer’s picture

eugenmayer commented

Thank you very much!

eugenmayer’s picture

eugenmayer commented
Version: 6.x-2.x-dev » 6.x-1.15
Status: Fixed » Active

Just installed 1.15 and it is not included. 6.2 dev actually broke bibtex and ris export ( not working at all ).

Are you going to include this in the 1.x branch at all?

rjerome’s picture

rjerome commented

No, I wasn't planning on it. 2.x will become the official release in the not too distant future.

eugenmayer’s picture

eugenmayer commented
Version: 6.x-1.15 » 6.x-2.x-dev
eugenmayer’s picture

eugenmayer commented

Actually i dont mean the export, rather the import. Thanks

rjerome’s picture

rjerome commented

Could you be more specific when you say "6.2 dev actually broke bibtex and ris import ( not working at all )", since it works fine for me. Are you seeing errors?

eugenmayer’s picture

eugenmayer commented

Well iam testing the dezember release right now, i used Nov 16 before. It might got fixed already. I report back with some detailed informations, sorry for beeing that unspecific

trigun’s picture

trigun commented
StatusFileSize
new biblio_pasting.patch3.22 KB

Enclosed I would like to provide a patch to this issue made against 6.x-2.x-dev, fixing the paste functionality for cases in which both RIS and bibtex submodules are enabled.

The issue apparently encountered by EugenMayer probably is that RIS and bibtex-submodules use form elements with the same name, hence this patch uses suffixes to namespace the elements. Also, bibtex #maxlength is removed.

Further steps: If the user fills both textfields, it would be nice to namespace the submit-buttons properly and add custom validators that remove other submitted fields...

eugenmayer’s picture

eugenmayer commented
Title: Fixed RIS import / implemented import from node form ( 6.2 -dev) » Fixing RIS / Bibtech import ( form element namespace issue ) / maxlenght issue

Just fixing the title. Thanks for the work trigun

rjerome’s picture

rjerome commented

Ah, when you said import, I thought you meant import from a file as opposed to pasting into the form.

Sorry about that.

Ron.

eugenmayer’s picture

eugenmayer commented
Title: Fixing RIS / Bibtech import ( form element namespace issue ) / maxlenght issue » Fixing RIS / Bibtex import ( form element namespace issue ) / maxlenght issue
Status: Active » Reviewed & tested by the community

We actually tested the patch

rjerome’s picture

rjerome commented
Title: Fixing RIS / Bibtex import ( form element namespace issue ) / maxlenght issue » Fixing RIS / Bibtech import ( form element namespace issue ) / maxlenght issue
Status: Reviewed & tested by the community » Fixed

committed patch in #17 to 6.x-2.x and 7.x-1.x branches.

eugenmayer’s picture

eugenmayer commented

Thanks rjerome!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.