FBSSC integration with Modal frame

I have reviewed the popups patch and made a better, cleaner version of fbssc to integrate with modal frame.
To me, it seems to be working.
I had to override facebook_status ahah handler but, in my opinion, fbssc.ahah.js could be merged with facebook_status.ahah.js; I think that also if you plan to add modal frame integration for edit/delete status this replacement could be useful.
I hope this helps.

• fbssc.ahah.js is the new AHAH handler: overrides fbss handler so that it can apply Drupal.settings before AHAH success event.
  It also define an ajaxComplete event so that if any AJAX request reload the entire page, the Drupal.settings for that page are extracted from the response. This is needed to attach AHAH behavior to comment submit buttons after facebook status update in user profile triggers an AJAX reload of the recent statuses view.
• fbssc.css contain minor css fixes.
• fbssc.js code is the fbssc javascript object:
  labelClickEvent() is needed to view/hide comment list;
  refreshCommentForm() fakes a comment submit to obtain the new form state. I thought that the only way to retrieve comments securely was by form post, so that the form token is checked. If you simply check permissions you don't have a way to distinguish which comment form it is (request can be faked); and looking at the code (fbssc_can_view(), fbssc_can_post()), you would wish to do so - maybe fbssc_save_js() should check fbssc_can_post(), this is missing! - . By the way I had to remove "required" field of the comment textarea to achieve this.
  Lastly, the file contains the modal frame client side integration, which is never activated if that module is not installed.
• fbssc.module is the big part of the work:
  I fixed the comment box form wrapper and layout so that the comment add/edit/delete cycle was effectively a cycle; as before, it wasn't so you couldn't keep adding then deleting comment without screwing the HTML on the page.
  Then I introduced a cache on theme_fbssc_form_display() - which is called server side both by AHAH refresh and by theming calls - so that a form doesn't get generated multiple times before sending the response, otherwise form token would not be the same on client and on server.
  Also, after fbss update submit, there is an abnormal situation where the function is called for every status on the page to render its comments, but the $sid parameter always refers to the newly inserted status. I think this has to do with the "if not passed in, get the latest status" policy of fbss... anyhow it's good to exclude from render in this condition because immediately afterward submit, fbss triggers an AJAX call to update the recent statuses view.
  Lastly there is the server side integration with modal frame, which consist in altering the edit/delete confirmation forms to operate in the frame.

... and that's all!

EDIT: This patch is a fix for #931358: FsSC: Comments not visible for anonymous users

The high level analysis is correct :)

The suggested workflow is correct, with the exception that content is replaced on edit and on delete, for simplicity; but of course, you could assign different ids to comments and know what you are hiding... EDIT: but actually you are true the ajax call is redundant.

And up to then there were 30 lines of code!

Then, the problem is: when you change status, the status list (with the respective comments) gets updated by AJAX. Now, it's needed to rebuild all AHAH behaviors, avoid form tokens desync and all the stuff that the patch take care of.

I attach a reviewed patch, that also fixes:
* namespace of _append_submit()
* an issue with comment folding on page statuses/[sid]
* some indentations

This was really the simplest solution I could find to make fbssc work with modal frame everywhere and in any case... but it might not be the best, or the only. Up to you deciding...

Ok, nevermind. I understand what you are saying, but it wasn't possible for me to make it work in that way.
I'll wait your next commit to see how differently you would make things. That might turn out to be a good learning occasion to me.

:) that was my purpose. I'll still be available if we need to discuss about it.

very good job!