So, we need a validation handler to stop it.

CommentFileSizeAuthor
media_youtube-validate.patch870 byteseffulgentsia

Comments

aaron’s picture

aaron commented

from a #ux perspective, seems like that should actually work, imho. if i have 500 videos in the system, and i try to enter a duplicate, seems like the system should simply recognize the old uri and send it through. otherwise, i'll get an error now, and need to sift through dozens or more pages of thumbnails to hopefully find the right one. fail. especially considering that there's no such restriction on uploading the same file twice (or a dozen times).

in early discussions of media, we'd actually wanted to have the media browser accept uri's rather than fid's, as this would then allow that by default. and, in fact, that's how it was originally implemented. not sure where along the way we changed that.

my idea would be to either fix media to allow accepting either an fid or a uri, or to have a fetched url translate to the correct fid if it already exists. because yes, obviously we don't want to cause a primary key violation.

JacobSingh’s picture

JacobSingh commented

+1. And when we have access control, imagine if two users try to link to the same video. That's actually an even scarier case, since it's not like we can rename the youtube URI. It would require a core change to "un-unique" the uri of course, but maybe we would need to. I'm not sure why it needs to be unique anyway. For the time being, I think this patch is worth committing though, even if it is a gross UX violation because the current state is much worse.

-J

aaron’s picture

aaron commented
Status: Needs review » Reviewed & tested by the community

well, if this blocking a release, let's go with it. i don't want to do an rc till we get this resolved in a better way though.

effulgentsia’s picture

effulgentsia commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS, along with this inline code comment:

// @todo Media module currently fails when two files try to have the same
//   URI, so catch that in the validation step. Some day, it would be nice
//   to allow it, however. See http://drupal.org/node/952422.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Niklas Fiekas’s picture

Niklas Fiekas commented

Subscribe.

peronas’s picture

peronas commented

Subscribe.

ksenzee’s picture

ksenzee
she/her
commented

FYI for subscribers, #1213184: Allow YouTube videos to be re-used was able to remove the temporary fix added here now that file_uri_to_object() allows you to reuse existing files.