We upgraded to Messaging and Notifications 6.x-2.2 yesterday and it broke our Notifications Framework.

We are using the Framework in combination with Mail Comment 6.x-1.x-dev (2010-Oct-07) as the 6.x-1.0 version has a bug which has been corrected in the dev version.

Prior to the upgrade of Messaging and Notifications yesterday the full 'round trip' of Message-Notification-Reply was working correctly. After the upgrade the 'round trip' failed, as far as we can tell for the following reasons:

1. Username incorrectly inserted in outgoing emails. (‘Guest’ substituted instead of poster’s username). Function messaging_mail_prepare (messaging.mail.inc) no longer uses sender_name which is the only parameter passed by Notifications. (Sender_account is not passed in this option). This change not included in Release Notes.

2. Incorrect reply-to value inserted in outgoing emails.

We have reverted to Messaging 6.x-2.2 and Notifications 6.x-2.2 today and our system is working again.

I have posted a copy of this report in the Mail Comment Issues.

CommentFileSizeAuthor
#2 messaging-952560-2.patch793 bytesgibus

Comments

davidteall’s picture

davidteall commented

Correction: We upgraded to Messaging and Notifications 6.x-2.3 yesterday and it broke our Notifications Framework. I got it right in the Header but not in the text.

gibus’s picture

gibus commented
Status: Active » Needs review
StatusFileSize
new messaging-952560-2.patch793 bytes

I confirm the problem with messaging 2.3, when notification sender is configured to "User name, site data (Only the user name will be used)" (notifications_sender=1), notifications are send with correct mail adress but with displayed sender incorrectly set to anonymous (I guess MedMan has configured anonymous user to be displayed as Guest).

Here's a patch that fix the pb.

pandroid’s picture

pandroid commented
Title: Messaging/Notifications 6.3 has broken our Notifications Framework » Messaging/Notifications 6.x-2.3 has broken our Notifications Framework

This patch corrects the previous behaviour, but exposes another bug.
We use mailcomment to manage replies to forums. Mailcomment inserts a reply-to address that now does not get detected by messaging and the email is transmitted without the reply-to set correctly.

Our reply email is in the format 'forum_replies@myca.org.uk'. Mailcomment does not insert a name.

The preg-match at messaging_phpmailer.module line 206 does not get any matches.
We have restored original behaviour by replacing the code at line 240 with the code in version 2.2