Active
Project:
JPIIM
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Oct 2010 at 22:39 UTC
Updated:
26 Oct 2010 at 17:58 UTC
Interesting concept for a module. Definitely wins points on controversial title.
Just wanted to make a couple recommendations after looking at the code.
1. Run it through a code review and clean up any points there. http://drupal.org/project/coder
2. There are a couple of spelling errors in the source, no big deal though
3. I don't think you do any check on seeing whether curl is enabled. Even though you state it uses curl you don't state that it explicitly requires it. I'd recommended using http://drupal.org/project/curl as a requirement.
Comments
Comment #1
rootedlogics commentedThank you for thee feedback. I will go in and make the improvements that you suggested. The two modules we committed over the past couple days are our first foray into contributing modules back to Drupal. I look forward to learning and adhering to the standard or best practices.
Comment #2
coderintherye commentedAnd I look forward to seeing your projects move forward, good work for your first forays into giving back. Cheers.