jplayer Drupal 7 version

I am thankful to see this patch.
I applied the patch and all changes were successfully made, except those to the info file, which I made by hand. However, when adding a file field to a content type, I don't see the jplayer widget as an option.

Thanks for the pointers. Once the docs are updated, this would be clear.

I am not getting it to play though. When I used the playlist, it would play if I advanced the "second" track, even though I had only uploaded one file. And, where the description should be, it is displaying the file id.

Any suggestions?

Actually, the problem that I was having had nothing to do with this patch. It would be good to use to form a D7 branch.

There is still an issue remaining. For display, I am using the single player, but the player is the not playing and the description is not showing up. I tracked the problem down to the preprocess function in jplayer.theme.inc.

function template_preprocess_jplayer(&$vars) {
  if ($vars['mode'] == 'single') {
    $item = current($vars['items']);
    $vars['item']['url'] = file_create_url($item['uri']);
    $vars['item']['label'] = $item['description'] ? $item['description'] : $item['filename'];
  }

$vars['items'] does not seem to be the right way to access the variables, for neither the description nor the uri are being set.

Alright, the single player works for me when I make this change jplayer.module on line 84:

- '#items' => $item,
+ '#items' => $items,

I would reroll the patch but I don't know how to create a patch for multiple files at once.

I still get an error showing $item as undefined for a single player.

I finally got back to this and cleared my cache, and it works just fine.

sub'ing and will test soon, will this patch get rolled into a 7.x-dev branch?

subscribe

Patch no longer applies to latest code.

I can has d7 branch plox?

I just want to gain clarity, does this patch no longer work? And how would I apply this patch anyhow?

> I just want to gain clarity, does this patch no longer work? And how would I apply this patch anyhow?

This patch will no longer apply as the development branch of the module has new code in it. See http://drupal.org/patch/apply for how to apply patches. Switching back to task.

at #16 this is exactly why I've been requesting a 7.x branch be created. At some point you have to fork it, might as well do it while there is a working patch. You would also get more thorough testing and accurate patches with 7.x-1.0-dev branch.

Subscribing. I would also like to see a 7.x branch be created..

I've done some work on switching jplayer to use the new libraries functionality in D7 core... which I will submit a patch for once there is a 7.x branch to commit to...

No need to wait for a 7.x branch, just make your diffs against DRUPAL-6--1

hmm that won't work if the changes require D7 core API functionality to work....

Your patch is against DRUPAL-6--1, but you're updating it for D7. It's not a problem. :)

Well I'm slowly chipping away at a patch for D7 while I have the time. Also bringing a lot of new features.

Here's an example of configurability on a single jplayer instance formatter.

Can you attach your patch? Thanks!

I've added a release which you can see here: http://drupal.org/node/786876/release

Still very unstable and possible unusable. But you might begin to see what I'm trying to achieve.

Thanks

Just an update. I've spent the day getting most of the basics in place for the single player instance. The new dev release will be packaged tonight.

New features:
- Supports jPlayer 2.0
- Added video support
- Ability to use a multi-value file field to store different kinds of media (e.g. m4v and ogv) along with poster artwork. The module will do the rest.
- Added JS library support in D7 for other modules to use the jplayer library provided by this module.
- Time format options added to global settings.
- Lots of individual instance settings like: autoplay, mute, volume, repeat, preload.

To do:
- Views support
- Playlist formatter
- Finalise theme settings

I'm probably also going to work on a new skin for jPlayer at some point.

I'm going to close this issue since there is now a D7 branch. Feel free to open up new issues against the 7.x-2.x-dev branch as needed.