Postponed
Project:
Bakery Single Sign-On System
Version:
3.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2010 at 15:51 UTC
Updated:
16 May 2025 at 17:01 UTC
Jump to comment: Most recent
Comments
Comment #1
damien tournoud commentedWell. It would help a ton if we could at least *document* the metaphors. I don't believe that the name of the cookies are a burden, the lack of documentation / rationale for the cookies is.
Comment #2
coltraneIt's true that there is no documentation for the cookies. But because the current cookies are functionality-specific, new cookies were added to handle things like slave log in and registration (#947692: Slave site registration when confirmation is required does not send email and #854202: Register and login on slave site. Or requesting user information from master #821436: Request account information from master.
We could document all these new communication methods, but I'd rather rewrite Bakery a bit to remove duplication in server to server communication, and client to server communication. Once that's done, if it's done, I'm OK with cookie metaphors (when the communication is actually a browser cookie).
Comment #3
juliangb commentedI totally agree with the OP - the metaphors are a burden.
I tried to get some documentation available a while back, see glossary issue. But it isn't something that can be done on one's own.
Comment #4
david straussI wrote Bakery to force us to finally integrate our usernames across *.drupal.org sites so that we would be in a position to move to better SSO tools in the future.
Most of that goal has been accomplished now. Groups (to pick the biggest subsite) is now using Bakery, and new sites tend to use it as a way to establish accounts consistently named with their Drupal.org counterparts.
I would really prefer to focus on better SSO tools to meet our long-term infrastructure needs.
Comment #5
david strauss@Damien The initial "rationale" for the naming of the cookies was that they happened to be the cookies available at the Chapter Three office during the redesign sprint. Later cookies were named by the contributor of the related code.
Comment #6
bowersox commented+1 to either documenting the cookie metaphors or converting the metaphors into self-explanatory names.
If we had a client-server diagram to show the sequence in the login process and the steps in master-slave communication, that would be great. Without that documentation, it makes the security model hard to grasp when reading the code. We are thrilled to be using the Bakery module on numerous client projects. But when we try to do a security audit to understand exactly how it works, the metaphors make it more challenging.
Don't get me wrong. We laughed out loud at all the cookie names. I personally don't believe there is such a thing as a "stroopwafel" cookie. ;-)
@DavidStrauss, are you putting your energy into a different SSO solution?
Comment #7
coltraneThere hasn't been much rallying behind separating Bakery's SSO functionality with its data synchronization. No one is to blame but perhaps me for not talking enough about it or starting on it. Instead I get clients that want to implement Bakery, which is ok too. So, I can provide some cookie documentation and potentially some diagrams.
One next step is to finish/commit #876130: Update Bakery documentation.
I think Bakery 2.x should be finalized (a stable release) and ported fully to 7, then perhaps we could talk more about removing cookie metaphors and separating SSO from sync. Marking this postponed.
Comment #8
david strauss@brandonojc I've done work with other systems, but I haven't put any of that into d.o infrastructure. My primary motivation is around security. Bakery uses a shared secret which, while not a vulnerability in itself, makes the system easier to compromise when there's a vulnerability in other code.
Comment #9
coltraneHere's a start on the cookie descriptions http://drupal.org/node/1113222
Comment #10
coltraneRelated #573888: You should not 'eat' a bad or poisoned cookie
Comment #11
purencool commentedComment #12
avpadernoThe used cookies and their names have not been changed, even in the 3.0.x branch. What described here is still actual.
Comment #13
avpaderno