Download & Extend

Validation and submission rely on exact ordering of form elements

Project:Ezmlm
Version:6.x-1.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I have a site where I have rearranged some of the ezmlm subscription form elements. This causes validation and submission to break. Here is a patch that fixes the issue. It's not perfect, either; maybe the right way to do it would be to put the mailing list checkboxes into a subelement and use #tree.

AttachmentSize
ezmlm-6.x-1.1_robust_submit.patch848 bytes

Comments

#1

Thanks for the patch, I'll have a look at it shortly.

#2

Version:6.x-1.1» 6.x-1.x-dev
Category:bug report» support request
Status:needs review» active

I have added theming for the form in the latest dev version, this is a much better way to reorganise the form without breaking the validate and submit functions. See function theme_ezmlm_subscribe_form() where you can change the order of elements without altering the keys, using '#weight'.
function theme_ezmlm_subscribe_form() should be copied to your theme's template.php, appropriately renamed and altered there.

#3

Status:active» fixed

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.