No output by Trim this field to a maximum length [#954238]

When I checked "Trim this field to a maximum length" I get no output.
My field was the bodyfield and the maxlength 110.

Comment	File	Size	Author
#16	view_bug.png	125.34 KB	ngmaloney

Comments

Comment #1

Letharion commented 27 October 2010 at 09:02

Status:

Active

» Closed (cannot reproduce)

Please read the issue submission guidelines.

I can't reproduce problems without a view and the data you run the view on.

Comment #2

klaus66 commented 27 October 2010 at 09:39

Status:

Closed (cannot reproduce)

» Active

Here is the view. My system local is a WAMP.

$view = new view;
$view->name = 'kaz_search';
$view->description = 'Stellt die Trefferliste des Kleinanzeigenmarktes bereit ';
$view->tag = '';
$view->base_table = 'node';
$view->api_version = '3.0-alpha1';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Standards */
$handler = $view->new_display('default', 'Standards', 'default');
$handler->display->display_options['use_more_text'] = 'Weiter';
$handler->display->display_options['group_by'] = TRUE;
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['exposed_form']['options']['reset_button_label'] = 'Zurücksetzen';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['expose']['items_per_page_label'] = 'Beträge pro Seite';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'fields';
/* Feld: Felder: field_kaz_image */
$handler->display->display_options['fields']['entity_id_1']['id'] = 'entity_id_1';
$handler->display->display_options['fields']['entity_id_1']['table'] = 'field_data_field_kaz_image';
$handler->display->display_options['fields']['entity_id_1']['field'] = 'entity_id';
$handler->display->display_options['fields']['entity_id_1']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['entity_id_1']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['entity_id_1']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['entity_id_1']['alter']['trim'] = 0;
$handler->display->display_options['fields']['entity_id_1']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['entity_id_1']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['entity_id_1']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['entity_id_1']['alter']['html'] = 0;
$handler->display->display_options['fields']['entity_id_1']['hide_empty'] = 0;
$handler->display->display_options['fields']['entity_id_1']['empty_zero'] = 0;
$handler->display->display_options['fields']['entity_id_1']['settings'] = array(
  'image_style' => 'thumbnail',
  'image_link' => 'content',
);
/* Feld: Felder: field_kaz_image */
$handler->display->display_options['fields']['entity_id_2']['id'] = 'entity_id_2';
$handler->display->display_options['fields']['entity_id_2']['table'] = 'field_data_field_kaz_image';
$handler->display->display_options['fields']['entity_id_2']['field'] = 'entity_id';
$handler->display->display_options['fields']['entity_id_2']['group_type'] = 'count';
$handler->display->display_options['fields']['entity_id_2']['exclude'] = TRUE;
$handler->display->display_options['fields']['entity_id_2']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['entity_id_2']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['entity_id_2']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['entity_id_2']['alter']['trim'] = 0;
$handler->display->display_options['fields']['entity_id_2']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['entity_id_2']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['entity_id_2']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['entity_id_2']['alter']['html'] = 0;
$handler->display->display_options['fields']['entity_id_2']['hide_empty'] = 0;
$handler->display->display_options['fields']['entity_id_2']['empty_zero'] = 0;
$handler->display->display_options['fields']['entity_id_2']['settings'] = array(
  'image_style' => '',
  'image_link' => '',
);
/* Feld: Beitrag: Titel */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['title']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim'] = 0;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['title']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['title']['alter']['html'] = 0;
$handler->display->display_options['fields']['title']['hide_empty'] = 0;
$handler->display->display_options['fields']['title']['empty_zero'] = 0;
$handler->display->display_options['fields']['title']['link_to_node'] = 1;
/* Feld: Felder: body */
$handler->display->display_options['fields']['entity_id']['id'] = 'entity_id';
$handler->display->display_options['fields']['entity_id']['table'] = 'field_data_body';
$handler->display->display_options['fields']['entity_id']['field'] = 'entity_id';
$handler->display->display_options['fields']['entity_id']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['entity_id']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['entity_id']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['entity_id']['alter']['trim'] = 1;
$handler->display->display_options['fields']['entity_id']['alter']['max_length'] = '110';
$handler->display->display_options['fields']['entity_id']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['entity_id']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['entity_id']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['entity_id']['alter']['html'] = 0;
$handler->display->display_options['fields']['entity_id']['hide_empty'] = 0;
$handler->display->display_options['fields']['entity_id']['empty_zero'] = 0;
/* Feld: Felder: field_standort */
$handler->display->display_options['fields']['entity_id_4']['id'] = 'entity_id_4';
$handler->display->display_options['fields']['entity_id_4']['table'] = 'field_data_field_standort';
$handler->display->display_options['fields']['entity_id_4']['field'] = 'entity_id';
$handler->display->display_options['fields']['entity_id_4']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['entity_id_4']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['entity_id_4']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['entity_id_4']['alter']['trim'] = 0;
$handler->display->display_options['fields']['entity_id_4']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['entity_id_4']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['entity_id_4']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['entity_id_4']['alter']['html'] = 0;
$handler->display->display_options['fields']['entity_id_4']['hide_empty'] = 0;
$handler->display->display_options['fields']['entity_id_4']['empty_zero'] = 0;
/* Feld: Beitrag: Aktualisierungszeitpunkt */
$handler->display->display_options['fields']['changed']['id'] = 'changed';
$handler->display->display_options['fields']['changed']['table'] = 'node';
$handler->display->display_options['fields']['changed']['field'] = 'changed';

/* Display: Seite */
$handler = $view->new_display('page', 'Seite', 'page_1');
$handler->display->display_options['defaults']['style_plugin'] = FALSE;
$handler->display->display_options['style_plugin'] = 'table';
$handler->display->display_options['style_options']['columns'] = array(
  'entity_id_1' => 'entity_id_1',
  'title' => 'title',
  'entity_id' => 'entity_id',
  'entity_id_2' => 'entity_id_2',
);
$handler->display->display_options['style_options']['default'] = '-1';
$handler->display->display_options['style_options']['info'] = array(
  'entity_id_1' => array(
    'sortable' => 0,
    'align' => '',
    'separator' => '',
  ),
  'title' => array(
    'sortable' => 0,
    'align' => '',
    'separator' => '',
  ),
  'entity_id' => array(
    'sortable' => 0,
    'align' => '',
    'separator' => '',
  ),
  'entity_id_2' => array(
    'sortable' => 0,
    'align' => '',
    'separator' => '',
  ),
);
$handler->display->display_options['style_options']['override'] = 1;
$handler->display->display_options['style_options']['sticky'] = 0;
$handler->display->display_options['defaults']['style_options'] = FALSE;
$handler->display->display_options['defaults']['row_plugin'] = FALSE;
$handler->display->display_options['defaults']['row_options'] = FALSE;
$handler->display->display_options['path'] = 'announce/%/%';

Comment #3

merlinofchaos commented 27 October 2010 at 16:15

Does the value you're trimming contain HTML? This is the leading cause of the problem you are seeing.

Comment #4

didox commented 27 October 2010 at 17:49

I have had the same problem and I ticked (provisionally) 'Strip HTML tags' and is ok. (I didn't use any html tag inside post) - strangely

my source html:

<div class="content">
    <div class="field field-name-field-image2 field-type-image field-label-hidden"><div class="field-items"><div class="field-item even"><img typeof="foaf:Image" src="xxx" alt="" /></div></div></div><div class="field field-name-body field-type-text-with-summary field-label-hidden"><div class="field-items"><div class="field-item even" property="content:encoded"><p>Quae populus interdico similisncidunt si abigo gilvus elit cui.Suscipit autem eu quae iaceo luptatum cui causa.  abigo eum</p>
</div></div>

Comment #5

Letharion commented 27 October 2010 at 18:07

Assigned:

klaus66

» merlinofchaos

@merlin
Could you please elaborate on "Is the leading cause"? I assume that trimming is supposed to be supported even with HTML, is it not?
Will this be fixed later, or is this "as designed"?

Comment #6

klaus66 commented 27 October 2010 at 20:01

In drupal 6 views it was no problem to trim the body. With or without html.

I think the body field is the most important field to trim.

Comment #7

klaus66 commented 27 October 2010 at 20:05

No I set the field to plain text and I control it with firebug and there was no html inside the body field.

Comment #8

merlinofchaos commented 27 October 2010 at 20:13

Assigned:

merlinofchaos

» dawehner

Often times you'll see stuff like this:

some long link text

And if it gets cut in the URL, the entire thing ends up cut because malformed tags are removed.

However, from the sound of this, it appears that there may be a bug in D7. Kicking this over to dereine to take a look at.

Comment #9

klaus66 commented 28 October 2010 at 10:11

When you check "Strip HTML tags " in the Views UI then it works.

Comment #10

dawehner

German

commented 28 October 2010 at 14:42

As you see

<div class="content">
    <div class="field field-name-field-image2 field-type-image field-label-hidden"><div class="field-items"><div class="field-item even"><img typeof="foaf:Image" src="xxx" alt="" /></div></div></div><div class="field field-name-body field-type-text-with-summary field-label-hidden"><div class="field-items"><div class="field-item even" property="content:encoded"><p>

This is just html without any content. This html is ~400 long, so truncating just returns html, without content.

So i guess the status should be "works as designed".

Comment #11

dawehner

German

commented 28 October 2010 at 20:00

Status:

Active

» Closed (works as designed)

Change the status is right.

Comment #12

Argus commented 5 December 2010 at 21:32

Status:

Active

» Closed (works as designed)

Forgive me for re-opening when there's probably tuns of important stuff for you to attend to, but why do you consider HTML output to be part of the field's content?

Shouldn't the trimming happen only on the text that is in the field?

Comment #13

Argus commented 5 December 2010 at 21:31

Status:

Closed (works as designed)

» Active

see above

Comment #14

bojanz commented 6 December 2010 at 10:42

In Drupal 7, Views doesn't render the field, that is done by Drupal 7 itself, and Views just passes it along.
So, the "trim" option is kinda useless for fields, since that should be done by the field formatter itself (Views allows you to select an appropriate formatter and change it's settings when adding a field. In this case it's the "Trimmed" formatter).

Comment #15

bojanz commented 6 December 2010 at 12:21

Status:

Closed (works as designed)

» Active

Here's a suggestion:

Remove the:
1. Trim this field to a maximum length
2. Strip HTML tags (actually, no real reason to remove this one)
options for Field API fields. This is already done by formatters, and duplicating it only causes confusion like above.

I know that a Field might not have a Trimmed formatter or whatever, but the point is that Views should leave these things to formatters.
A field tells us how it wants or can be rendered, we pass the choice to the user, without guessing anything.
Separation of concerns, nothing more or less.

Will roll a patch in the next 24h, giving you all time to disagree (and merlinofchaos and dereine to "won't fix" it if they think I'm insane)

Comment #16

ngmaloney commented 31 January 2011 at 16:23

Status	File	Size
new	view_bug.png	125.34 KB

I was having the same issue; adding a text field and trimming length would display empty text when rendered. The catch was this was only happening on our development server, not my local MAMP install. Upon further inspection I discovered that when running php 5.3 truncation worked fine but when running php 5.2.x it would not work at all.

Running:
Drupal: 7.0
Views: 7.x-3.0-alpha1
Ctools: 7.x-1.0-alpha2

View code is here. Attached is a screen shot of the blocks to illustrate bug.

Comment #17

dawehner

German

commented 27 February 2011 at 10:02

1. Trim this field to a maximum length
2. Strip HTML tags (actually, no real reason to remove this one)
options for Field API fields

Mh. It's a common use for many users.
So you force every formatter for any kind of field to have the trim functionality.

For example if there would be a formatter for image description, you would need trim there, which really is kind of interesting.
Makes this sense? Perhaps you was just in the "oh fieldapi integration is totally broken"-mode :)

Comment #18

Sunlight Studios commented 14 March 2011 at 14:58

Exactly the same symptoms here, everything working perfectly on my laptop running 5.3, empty output on live server running 5.2 - I managed to track the problem down to PHP's own mb_substr() function but have yet to figure out why it's acting this way or how to get around it.

Basically the Views handler calls views_trim_text() which calls drupal_substr() which calls mb_substr(). I'm new to developing for D7 so I don't know how feasible it is to pull out the full length of content with Views and then use custom code to trim it, perhaps in template.php or in a field template file somewhere... am looking into it today as I need a quick fix!

Comment #19

merlinofchaos commented 28 March 2011 at 01:55

Interesting. I'm not having a problem trimming fields with the latest code, running PHP 5.2.something.

Comment #20

merlinofchaos commented 29 March 2011 at 19:54

Status:

Active

» Closed (won't fix)

If you've got a PHP with a broken mb_substr() there really isn't anything we can do about that anyway, except urge you to get a non-broken PHP version. :)

To address earlier comments: We can't parse the HTML to see what is content and what isn't and trim only that content. That's a level of intelligence that we're simply not going to code up and not going to force on users who don't need it, wasting CPU cycles.

Comment #21

johnpitcairn commented 3 February 2012 at 22:59

If you do want to waste CPU cycles parsing the html to trim only user-visible content, I've been having some initial success with code from http://snippets.dzone.com/posts/show/7125, used in hook_views_pre_render() on the appropriate text field's ['rendered']['#markup'].

No output by Trim this field to a maximum length

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

News items

Our community

Documentation

Drupal code base

Governance of community