Suppress feed icon in themes that override theme_feed_icon()

I will look into this.

here the one did it for me

/**
 * Implementation of hook_theme_registry_alter to override theme_feed_icon().
 */
function rss_permissions_theme_registry_alter(&$theme_registry) {
  $theme_registry['feed_icon']['function'] = 'rss_permissions_theme_feed_icon';
}

/**
 * Overriding theme_feed_icon().
 * Check permission to view the feed before displaying the icon.
 */
function rss_permissions_theme_feed_icon($variables) {  
  if (rss_permissions_feed_url_access($variables['url'])) {
	return theme_feed_icon($variables);
  }  
  return '';
}

also check #945462-4: Port to Drupal 7

Thanks for this!
I just made a commit to DEV version with this code, with a few changes. It should be available for download sometime today.

If we just call theme_feed_icon(), this does not use any custom theme function to style the icon. The goal of this ticket was to integrate the module with custom theming functions specifically. Right now I'm saving the current theming function name as a variable, and forcing Drupal to use our function. If the RSS icon should be displayed, then I get the theming function name from the variable, and call that.

This approach seems to work for me.

Here's a patch that removes the header <link> element (for RSS autodiscovery), plus some coding standards (whitespace changes). It checks to see if the full URL for a site is passed to rss_permissions_feed_url_access() then removes the base URL, and does a check for whether the path is a system path or an alias, so that it can work with the system path.

Hey, @Richard, did you mean to upload your patch to #945462: Port to Drupal 7?
This issue is specifically regarding the feed icon implementation in custom themes.

Sure, I guess.

Thanks, Drew!
Now as soon as this Git migration is done and I figure out how it works, I'll make a new module release with this update!

Subscribing