I went to add a Panel node and after I selected the layout, I got these notices.:

Notice: Undefined index: query in /sites/all/modules/nodeformsettings/nodeformsettings.module on line 294

Notice: Undefined index: fragment in /sites/all/modules/nodeformsettings/nodeformsettings.module on line 294

I attach an image. Is this because of the panels undefined property shown in the image. Or is this a nodeformsettings issue?

Comments

lelizondo’s picture

Version: 6.x-1.5 » 6.x-2.x-dev
Status: Active » Fixed

This was solved in 6.x-2.x please reopen if necessary

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

john.money’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new1.57 KB

Installing 2.x-dev (2011-Apr-13) I get 3 undefined index errors.

1. attempt to use nodeformsettings_purge after $values['var'] has already been unset
2. very aggressive preprocess_page function on pages that are not nodes (I'd vote to kill that function entirely)
3. attempt to modify body rows when body is hidden with Submission form settings

Attached patch fixes these.

lelizondo’s picture

Is this for 6.x-2.x?

About 2, do you know a better way to do it? I don't see that you remove the function in your patch.

john.money’s picture

Yes, 6.x-2.x.

re: \preprocess_page... hiding the node title seems such an edge case to me and unrelated to the node edit form like the other functionality, but its one small bit of code in an otherwise good module. I can live with it either way... :)

lelizondo’s picture

I actually use it a lot, it is specially useful when using Panel Nodes and I found out that many users are actually using it, although I get that the functionality might indicate that it has nothing to do with the Node Form, since it's acting on Node View.

  • ksbalajisundar committed cb4ac7f on 6.x-3.x
    Issue #955108 by ksbalajisundar: Fix for undefined indexes.
    
kssundar’s picture

Issue summary: View changes
Status: Needs review » Fixed

Ported to 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.