Match results change upon saving

How do you mean match results appear to change? I'm not sure how things could change. If you could let me know how to reproduce the error, I could take a look.
Thanks
Alun

I'll need to take a closer look bwax, I can't really understand what is wrong. I got your email, and will get back to you. Don't think I'll be able to do anything too soon though, as I am very busy currently.
Alun

There's obviously something going wrong with the updates. The update is mixing the results. The results stay the same (example: 0-2 stays 0-2) but aren't attached with the right matches. They stay in the same matches of the same week of the same league, but are just mixed up, and that isn't right, right? :-)
I'll take a look at the code this afternoon, but that isn't very simple as I didn't program the code myself...

Here the same

hi bwax,

Tx s for the reply: if I understood you well, you edit the match and put there the scores, match per match?
Kind of a dirty job, I have to put in the scores for 80 matches each week... :-)
Maybe it goes faster then, putting the scores directly in the db?

Ah I see what you mean now, its with the match admin interface, OK I'll take a look at whats going on.
Thanks
Alun

hi Alun,

yes that's what we mean. If you update matches to put in the scores in the match admin, scores get mixed up everytime. I think at first sight that it has something to do with the ordening in the listing. It surprised me at first time getting another order than ordered by id... Without having searching for the details, i think that the scores are mixed up by matchday, meaning that, when putting in 8 scores for matchday 11, those 8 scores are mixed up in the scores for the 11th week.

Alun could this be the problem my client had? I had to put back à backup to fix it.

Possibly a problem? I still haven't been able to replicate the error so I'm trying! If anyone has a SQL dump of their drupal installation which I could install and try out, that might help me. I'm setting up a league with 8 matches and entering results but its working OK for me.

Arun,

I'm having the problem by inputting more matches. First input is ok. Inputting another 8 matches is also ok, but updating the 8 scores of the matches by the match admin goes wrong.
If necessary I can give you sql dump by ftp because limit of upload of attachments is set at 1 mb here...

Hi kukle that would be cool. I got your email a while ago, but my replies have bounced, is your email in Drupal still valid?
Alun

Rrrrrrrrrrright...
There was a typo in it updating a few days ago...
txs for the remark.
Please send me a mail and i'll give you the passw...

The shortest way now: everything works great when adjusting the nodeid of the match in the adress-bar. Editing the score this way works just fine. Only the bulk operation adjusting the scores in the admin match interface doesn't do the job right ...

It's a very weird issue. My season is almost halfway and never had any problems. But my client updated the scores once and than i had this issue. I didn't have it myself yet!

@Alun: can i update my site with the newest version? Which changes happened?

I'm still working on this, once I can confidently reproduce the error I'll fix it. I've not got a lot of time on Leaguesite at the moment, but it will get fixed.
@Kukle, I used the SQL you gave me so I have a substantial amount of data to play with, that should help. Thanks
Alun

I can't reproduce it either. It's a strange buggy...

If the problem is with results already entered, the best solution at the moment will be to filter by match result, so that matches with results entered will not be affected when you submit the form.
I'll continue looking.

Last week I also had this idea, and filtered by matchday so I just had the results of the matchday showing up. But still there was something going wrong. I just can't remember what ... :-(

Edit: -> Any news on this?

No news from my end, I'm still trying to confidently reproduce the error. I'm not working around the clock on it though, so if anyone has any thoughts, please feel free to chip in.
I hope to update some code soon. I'll update here when I do.
Thanks
Alun

I'm having the same problem. After updating a group of matches, in my case all of Matchday 1, the results come back one index off. In other words:

The data entered on line one is on line two, data on line two is on three, etc.

So, I think this may be an index problem during the database update.

If I can figure out where is the code to modify this, I'll let you know if I can fix it!

Okay... here's what I discovered:

I think the problem is related to to the fact that all of my match times for Matchday 1 are the same. In this case, each time I open admin/content/leaguesite/matchadmin (filtered by Matchday 1), the list at the bottom (of matches), keeps changing order since the list is ordered by match time and all match times for my matches are the same.

So, if I add an additional order by criterion in leaguesite_match.admin.inc in the function leaguesite_match_list:

ORDER BY {leaguesite_match}.match_time, {leaguesite_match}.nid

(Adding the nid to the sort criteria on approx. line 526)

Then the problem goes away!

Since the update is evidently dependent on the order in which the database returns records, I suggest adding this additional sort criterion. This has the added benefit that if you have match times the same (as in my case), the matches stay in the order in which you entered them, making it easier to update scores later.

Thanks webtoad, good spotting! I'll try and get a patch up tonight for this.
Alun

I know you don't have a lot of time Alun so i provide you a patch for #25 :)

many thanks Masterchief, I was genuinely going to get this done tonight, but thats saved me time!
Alun

Happy to help (^_^)

Committed to the latest dev!