Download & Extend
Issues

Doc cleanup for menu_set_active_trail

Posted by dstol on October 28, 2010 at 10:49pm
Project:Drupal core
Version:6.x-dev
Component:documentation
Category:task
Priority:normal
Assigned:dstol
Status:closed (fixed)

Issue Summary

Just some coding standard things to clean up http://api.drupal.org/api/function/menu_set_active_trail/6

Login or register to post comments

Comments

#1

Posted by dstol on October 28, 2010 at 10:51pm

Here's the patch.

AttachmentSizeStatusTest resultOperations
menu_set_active_trail-956320-1.patch1.57 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu_set_active_trail-956320-1.patch.View details

#2

Posted by jhodgdon on October 28, 2010 at 11:05pm
Status:needs review» needs work

Cleaning up is OK, but not a very high priority for Drupal 6 at this time. I'd also avoid filing huge cleanup patches for D7 (small ones like this would be OK).

This is not quite right:

+ *   - type: A menu type constant, such as MENU_DEFAULT_LOCAL_TASK, or 0 to
+ *      indicate it's not really in the menu (used for the home page item).

Indentation on the 2nd line should be two additional spaces, not 3.

#3

Posted by jhodgdon on October 28, 2010 at 11:07pm
Version:6.x-dev» 7.x-dev

Oh.

Actually, this same formatting problem exists in D7 too. We need to fix it there before we can accept a patch for D6.

#4

Posted by dstol on October 28, 2010 at 11:19pm
Version:7.x-dev» 6.x-dev
Status:needs work» needs review

D6 fixup, D7 coming.

AttachmentSizeStatusTest resultOperations
menu_set_active_trail-956320-4.patch1.57 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu_set_active_trail-956320-4.patch.View details

#5

Posted by dstol on October 28, 2010 at 11:24pm
Version:6.x-dev» 7.x-dev

D7 cleanup removing the single quotes.

AttachmentSizeStatusTest resultOperations
menu_set_active_trail-d7-956320-5.patch1.21 KBIdlePASSED: [[SimpleTest]]: [MySQL] 26,751 pass(es).View details

#6

Posted by jhodgdon on October 29, 2010 at 2:28pm
Status:needs review» reviewed & tested by the community

The D7 patch in #5 is fine. thanks.

The D6 patch in #4 is also fine. So after committing to D7, please set to D6 / RTBC, thanks...

#7

Posted by Dries on October 30, 2010 at 4:13am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#8

Posted by dstol on October 30, 2010 at 4:58am
Version:7.x-dev» 6.x-dev
Status:fixed» reviewed & tested by the community

Setting as RTBC for 6.x-dev as per #6

#9

Posted by Gábor Hojtsy on November 3, 2010 at 12:00pm
Status:reviewed & tested by the community» fixed

Committed, thanks.

#10

Posted by System Message on November 17, 2010 at 12:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.