Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
28 Oct 2010 at 22:49 UTC
Updated:
17 Nov 2010 at 12:10 UTC
Jump to comment: Most recent file
Just some coding standard things to clean up http://api.drupal.org/api/function/menu_set_active_trail/6
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | menu_set_active_trail-d7-956320-5.patch | 1.21 KB | dstol |
| #4 | menu_set_active_trail-956320-4.patch | 1.57 KB | dstol |
| #1 | menu_set_active_trail-956320-1.patch | 1.57 KB | dstol |
Comments
Comment #1
dstolHere's the patch.
Comment #2
jhodgdonCleaning up is OK, but not a very high priority for Drupal 6 at this time. I'd also avoid filing huge cleanup patches for D7 (small ones like this would be OK).
This is not quite right:
Indentation on the 2nd line should be two additional spaces, not 3.
Comment #3
jhodgdonOh.
Actually, this same formatting problem exists in D7 too. We need to fix it there before we can accept a patch for D6.
Comment #4
dstolD6 fixup, D7 coming.
Comment #5
dstolD7 cleanup removing the single quotes.
Comment #6
jhodgdonThe D7 patch in #5 is fine. thanks.
The D6 patch in #4 is also fine. So after committing to D7, please set to D6 / RTBC, thanks...
Comment #7
dries commentedCommitted to CVS HEAD. Thanks.
Comment #8
dstolSetting as RTBC for 6.x-dev as per #6
Comment #9
gábor hojtsyCommitted, thanks.