CTools also provides a preprocess_page function that runs after this module and overrides the functionality for theme development settings. I have created a patch that sends the FALSE value for $preprocess back to drupal so that when ctools or any other module tries to rewrite the stylesheets they will respect the work this module has done. The problem though is ctools will overwrite the @import statements, so I don't have a solution for sites with > 31 stylesheets, which is probably the sole reason for this module's existence. Is there anyway to force this function to run AFTER ctools?

CommentFileSizeAuthor
#7 956416-ctools-incompatibility.patch1.08 KBjohnalbin
ie_css_optimizer_ctools_compatibility.patch1.16 KBmstrelan

Comments

plousia’s picture

plousia commented

Any update on this? I'm looking at using this module on a site which also uses CTools, so it'd be great if this was worked out.

zed_den’s picture

zed_den commented

I´ve got the same Problem... is there an update in progress?

plousia’s picture

plousia commented

This blog post includes some code to put into template.php which apparently fixes the IE stylesheet limit. Since it runs after modules it should get around this problem.

henrijs.seso’s picture

henrijs.seso commented

it does, thanks for a link!

henrijs.seso’s picture

henrijs.seso commented

aaannnnd no, tip in link does not work since it adds back styles overriden in template .info file

henrijs.seso’s picture

henrijs.seso commented

OP - set module weight?

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Needs review
StatusFileSize
new 956416-ctools-incompatibility.patch1.08 KB

I have ctools enabled on my d6 test system, but I'm not experiencing this issue.

However, its pretty trivial to make this module's preprocess_page hook run after ctool's.

Since I can't recreate the problem, please test this patch or checkout the 956416-ctools-incompatibility branch in Git. I won't add this to the module unless the patch is shown to fix the problem.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

Also, I'd like to point out that you'd need to test 2 things.

1.) that the functionality of this module starts to work with the patch applied, and
2.) that the functionality of ctools isn't broken in any way with this patch. specifically, merlinofchaos said to check that CSS adding during AJAX operations continues to work.

Anclywen’s picture

Anclywen commented

Patch solved the problem.

In my case, the problem was not ctools module, but in seven template (exactly in function seven_page_preprocess().

It will work under assumption that the previously called modules will overwrite $vars['styles'] using drupal_get_css() function (which causes the need to alter the array $vars['css']).

I must confirm that patch does not affect on the seven template or block the ctools' ability to add new css file (checked on ctools_ajax_sample module).

Everything, seems to be ok. It's should be merged.

soulfroys’s picture

soulfroys
Primary language Portuguese, Brazil
commented
Status: Needs review » Reviewed & tested by the community

#7 Works! Tks!