Noticed that media_mover generates quite a bit of notices:

	•	Notice: Undefined index: mmfid in media_mover_api_file_fetch() (line 2816 of/Users/macbookpro/Sites/m3com/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined index: harvest in media_mover_api_page() (line 1507 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined index: harvest in media_mover_api_page() (line 1507 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined index: complete in media_mover_api_page() (line 1507 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined index: process in media_mover_api_page() (line 1507 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined index: harvest in media_mover_api_page() (line 1507 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined index: 2 in media_mover_api_get_configuration() (line 1241 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined variable: status in media_mover_api_configuration_files_count() (line 2660 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).
	•	Notice: Undefined variable: status in media_mover_api_configuration_files_count() (line 2660 of/Users/macbookpro/Sites/test/sites/all/modules/media_mover/media_mover_api.module).

Attaching a patch that fixes the ones I noticed.
Preserved the if (! $condition style, even if it's against the coding standards.

Cheers.

CommentFileSizeAuthor
notices.patch2.43 KBbojanz

Comments

arthurf’s picture

Committed, thanks for the patch.

mikeytown2’s picture

Status: Needs review » Fixed

This patch is in the latest dev. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.