Closed (fixed)
Project:
Creative Commons
Version:
6.x-1.0
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Oct 2010 at 08:47 UTC
Updated:
22 Jul 2011 at 13:36 UTC
When selecting "all right reserved", 3 icons attempt to show up in this order:
all.png
all-rights-reserved.png
reserved.png
Only the middle one displays "C"
The other are broken links as these icons do not exist.
What's wrong?
- the module rightly calling for missing icons
- the module wrongly trying to call irrelevant icons?
Thanks
Comments
Comment #1
Sylvain Corlay commented+1
I also have the same issue with all.png and reserved.png
Comment #2
hongpong commentedSubscribe - this must come from the API, there is no 'all.png' in the code.
Comment #3
hongpong commentedAlso this is on dev not just RC so i'll switch it.
Comment #4
jvieille commented+1
Comment #5
kreynen commentedI believe this was only an using the icon setting. The icon option includes an extra option for displaying $, €, ¥. That setting is available in the admin settings for all options, but only impacts the display when icon is selected. I added some additional text to that effect to the form, but it would be nice if "someone" added some javascript so that setting wasn't even an option unless Icons was selected.
@HongPong is right. There is no all.png in the code. In the get_image function in creativecommons.class.php the path to the images is dynamical generated by code like...
For Icons, the code is different...
So all-rights-reserved was getting split up into all, rights, and reserved and only fixed once by the $filename == 'rights' check.
I committed a fix, but that whole functions needs some love.
Comment #6
MPetrovic commentedComment #7
kreynen commented