Download & Extend

Admin toolbar obscures overlay

Project:Admin
Version:7.x-2.0-beta3
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

If then admin toolbar is expanded and an overlay is opened the over is obscured. The work around is to close then reopen the admin toolbar, which is annoying.

Comments

#1

Status:active» needs review

The attached patch fixes this issue. There are a couple of related changes rolled into the patch too, they are:

* Moving width/height from a magic number to a constant (Drupal.adminToolbar.SIZE)

* Move resize overlay resize animation into a separate method (setOverlayState) and reduce code duplication

I am binding to the drupalOverlayLoad event rather than the drupalOverlayOpen event, as the open event seems to fire before the admin toolbar behaviors are setup. The down side is some extra logic will be executed on each overlay load.

I may have gone overboard on the documentation for setOverlayState, feel free to trim it.

AttachmentSize
admin-958182-covering-overlay.diff 6.86 KB

#2

Status:needs review» fixed

Thanks, http://drupal.org/cvs?commit=465704

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#4

Version:7.x-2.0-beta2» 7.x-2.0-beta3
Status:closed (fixed)» active

I'm still seeing this in 7.x-2.0-beta3. Screenshots attached.

AttachmentSize
Screen Shot 2011-09-20 at 3.07.32 PM.png 288.64 KB
Screen Shot 2011-09-20 at 3.07.34 PM.png 290.29 KB

#5

Status:active» fixed

This is fixed in the current nightly builds. See r-35fe189.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#7

Status:closed (fixed)» active

this still doesnt work correctly if State on new pages: Collapsed