Flag friend access control to limit node types - patch

Hi sirkitree.

I love this module but can't use it without the ability to specify which content types use the friend access control functionality. For example, I'm using Content Profile on one site, so the FAC checkbox is currently appearing on the registration form, and the only way to remove it is to disable Flag friend.

Are you planning to roll this patch into future releases? I'd love to be able to use it but I'm wary of patching modules unless I'm confident it's not going to come back and bite me when I upgrade.

Thanks

Sure, as soon as it's reviewed by someone and proven to work. On a cursory glance it seems that you also have German translation stuff in this patch, which is outside the scope of what you originally posted as the topic. Please separate that stuff and open a separate issue. The smaller this patch is, the easier it will be for someone (or myself) to actually review and test.

Looks good. Will commit soon. Waiting on git migration before doing any more commits.

I'd like to redo this actually.

Currently we're altering the node form to add this in, but I would actually expect this to be on the flag settings page when you enable the friend flag so that all of the settings are in one place.

This should looks something like the current 'Flag Access' fieldset, but be called 'Flag Node Access' and have a list of node types available to the system.

When saved, the data should be part of the flag_options in the flag table, which will make this data exportable inherently.

Is it possible that the node having "Only my friends" tag, not exported in RSS feed with other content ?

Really need to be able to disable this for a certain content type, is this still not possible?

I suppose I can just CSS it away