CVS edit link for ash0815

I want like help to create small mini modules and so and my motivation is Drupal.

A module is present, see drupalcenter.de/node/16446#comment-109990 and I have collaborated (see: http://www.drupalcenter.de/node/16446#comment-112058). It's currently for Drupal 6 only, another (mini) module will follow.

Thank you.

Regards Alex

Comments

ash0815’s picture

Protect Root

Here comes a module that was developed by codeherr and it's orginally from protect "critical users". My task was, that I add some functions, see readme.txt

This module has small blemishes, messages are assigned incorrectly or another appears, because of this module, but the module is functional.

Scyther’s picture

Status: Postponed (maintainer needs more info) » Needs work

Read this http://drupal.org/cvs-application/requirements and all pages that it links to and you may se what you have missed and why you havn't got any review.

I took a quick look at your code and it was not following coding standards so read this to http://drupal.org/coding-standards and you might want to use http://drupal.org/project/coder to have your code checked.

avpaderno’s picture

Issue tags: +Module review

Hello, and thank you for applying for a CVS account.

As per requirements, the motivation message should include a description of the module features, and a comparison with the existing solutions.

ash0815’s picture

Title: ash0815 [ash0815] » Protect Root
StatusFileSize
new7.89 KB

Hello,

this module was checked again. According to Coder module of the code is now compliant.

Description: This module protects the root user (id 1). The root user can not delete itself or by a user is deleted or disabled. The root user can only change its data, other users are denied access and receive a message. This module is currently running with Drupal 6

This module does not write data into the MySQL database.
Module simply copy in sites/all/modules and activate the module.

Highlights:

  • root can not delete or lock himself
  • other users with admin privileges can not edit the root, delete or block
    • German-language translation (po file) included in the archive.

      My motivation: I want to contribute to Drupal a little bit as far as possible on my part. How exactly does it with the CVS, I don't know. At the moment I get there through yet. A CVS client is installed.

avpaderno’s picture

Title: Protect Root » ash0815 [ash0815]
Status: Needs work » Needs review
drupalshrek’s picture

Hi,

Can we have a comparison with existing solutions? e.g.:

  • What modules exist with similar functionality?
  • If none, what exist at least in nearby domain?
  • What are the things which differ?
avpaderno’s picture

Status: Needs review » Needs work

I am changing status as per previous comment.

zzolo’s picture

Component: Miscellaneous » miscellaneous
Status: Needs work » Closed (won't fix)

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.