Active
Project:
ECO (Extra Customization Options for Ubercart)
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Oct 2010 at 21:07 UTC
Updated:
29 Nov 2010 at 05:50 UTC
So I have the "remove empty attributes" disabled, however looking at the code, uc_eco still reconstructs the entire attributes description array.
uc_eco_product_description_alter should not modify the description array at all if "uc_eco_main_cart_remove_empty_attributes" is not set, and if it is set it should *not* simply call _uc_cart_product_get_options and blow away whatever was in the description array, as there may be other modules with implementations of hook_product_description_alter that alter that descriptions array first. The call to _uc_cart_product_get_options does *not* return the descriptions with their weights, so its not a great way to get the options in any case.
Comments
Comment #1
WebNewCastle commentedHi,
Sorry I didn't see your post earlier. It sounds like this section could use some work. If you have specific additional suggestions, please feel free to post further :-) - I'll try to include this in things that I review in the coming weeks to move this close to another release.
Thanks!
- Matt