comment_notify_schema() claims that the notify column in the comment_notify table is 'A boolean indicator for whether or not they subscribed: 1 means subscribed, 0 means not subscribed.'. This is inaccurate because it can sometimes contain 2 (COMMENT_NOTIFY_COMMENT).

CommentFileSizeAuthor
#6 958670_6_comment_notify_docs.patch1.49 KBgreggles
#2 958670_2_comment_notify_docs.patch2.47 KBscor
#1 958670_1_comment_notify_docs.patch2.43 KBscor

Comments

scor’s picture

scor commented
Status: Active » Needs review
StatusFileSize
new 958670_1_comment_notify_docs.patch2.43 KB

Proposed wording:

A integer indicating the type of subscription: 0 means not subscribed, 1 means subscribed to all comments, and 2 means only subscribed to replies of this comment.

also includes some indentation fix in the same file.

scor’s picture

scor commented
StatusFileSize
new 958670_2_comment_notify_docs.patch2.47 KB

minor grammar fix.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

Thanks scor!

As long as we're fixing this how about some descriptions on node_notify and comment_notify?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

removing spam tag

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 958670_6_comment_notify_docs.patch1.49 KB

I think these are right now.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Fixed in 7.x and 6.x http://drupalcode.org/project/comment_notify.git/commit/448de8e http://drupalcode.org/project/comment_notify.git/commit/dc9207f

Thanks, scor.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.