MCP [mcp]

Hello, and thanks for applying for a CVS account. As per requirements, the motivation message should also include a description of the module features, and a comparison with the existing solutions.

Hi MCP. I haven't run the module but looking at the code here are some things to improve:

1/
Coding standards: You are using different indentation across functions. Drupal standard is two whitespaces. Also some docstrigs are not well formed. You can use coder module for this purpose.

2/

  $link = $GLOBALS['base_url']."/node/".$node->nid."/edit/".$password;

instead use url("/node/".$node->nid."/edit/".$password, array('absolute'=>TRUE)).

3/
it is just a suggestion: inform the user that the edit link is valid for a period of N days.

4/
other suggestion:

  $items['node/%node/edit/%'] = array(

you can create a function called editlnk_load() and use $items['node/%node/edit/%editlnk'] so it loads an editlnk object and pass it to editlnk_access().

5/
I think you're showing an edit link for everyone and it should only be given to anonymous users.

6/
other suggestion: remove edit links (via hook_cron) two or three days after the link has expired.

7/
perhaps instead of selecting valid content types. Make it work for content types which anynymous is allowed to post.

8/

  $row->nid = $node->nid;
  $row->editlnkid = $password;
  drupal_write_record('editlnk', $row);

This code raises a warning in E_STRICT mode and also in php 5.3. Create the object first.

9/
leverage user_password() to obtain a random alphanumeric string.

10/
I wanna use this module! :)

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

I am changing the status to Won't fix, since the OP doesn't have an account anymore.