Closed (won't fix)
Project:
Nodewords: D6 Meta Tags
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2010 at 13:07 UTC
Updated:
25 Sep 2020 at 14:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaPatch supplied that does not run trim($path, '/') when the default value is "[site-url]".
Comment #2
damienmckennaAlternatively, should it just check to see if the current site is the homepage?
Comment #3
damienmckennaOr both? =)
Comment #4
damienmckennaLets fix this for v6.x-1.12.
Comment #5
dave reidWhy are we removing trailing slashes? We should just remove that code.
Comment #6
dave reidOh I think the intent here may have been to prevent tokenized strings like '/node' from getting run through url(). If that's the case we should convert this to a ltrim() rather than the more greedy trim().
Comment #7
damienmckennaSomething like this?
Comment #8
dave reidyep that seems like the better option
Comment #9
dave reidReviewing this again, we'd probably actually want to skip if the URL is already absolute, as it's pointless running through url() again at that point. Something like:
Comment #10
damienmckennaThis may need some work, given we've reverted everything back to the last changes on December 31st, 2009.
Comment #11
damienmckennaBumping this to the 6.x-2.x branch which includes support for Tokens, the remaining 6.x-1.x branch does not.
Comment #12
damienmckennaMarking all v2 issues as postponed while v1 is finished off.
Comment #13
damienmckenna