Drupal 7 port

Will a dev version available soon or no port started yet?

Subscribe

Subscribe - using this in drupal_wiki so I am interested in its progress. thanks!

Looking forward fr it +1

Is someone already working on this port ? If not, I'd like to give it a try during the (shameless plug) DrupalGov Days (April 9).
I'm not that familiar with Drupal development, but it seems a rather easy - yet useful - module to get started...

I started on a port to D7, but it still needs a lot of work. Biggest thing left to do is actually get the comments moved from the "view" tab to the "talk" tab. After that is finished, it will need general style/formatting cleanup.

Bart (or anyone else) ping me when your ready to start so we can coordinate efforts.

This one should work in D7.

2nd Iteration. There's probably still a lot of code that can be cleaned up but appears to be working on D7. After I've verified the test cases are working I'll figure out how to submit the whole module as a patch for D7 (never done that before)

Patch against head.

rerolled against master

Sorry for the triple post. I was trying to get it to recognize the patch and initiate the test.

All three patches are the same.

#16: 959518-drupal7port_0.patch queued for re-testing.

Will we get a (dev) release soon?

JohnnyX,

My patch needs to be reviewed before it can be committed (and possibly turned into the d7-dev branch).

If you grab the patch, and test it against your d7 install, then provide feedback that might help move the process along.

-D

Patch was build using git.

For the long version See "Applying Patches" here http://drupal.org/node/1054616#applying-patches

For the short version you need to clone talk from git.

git clone http://git.drupal.org/project/talk.git

then download the patch into the talk folder

wget http://drupal.org/files/issues/959518-drupal7port_0_2.patch

then run the git command for applying the patch

git apply 959518-drupal7port_0_2.patch

you might get some errors about additional whitespace, but the patch should apply

Macintosh-2:talk davidhazel$ git apply 9.patch 
9.patch:28: trailing whitespace.
5. If you'd like to change the text used in a variety of places go to 
9.patch:412: trailing whitespace.
 * 
9.patch:42: new blank line at EOF.
+
9.patch:379: new blank line at EOF.
+
warning: 4 lines add whitespace errors.

i agree it is stable and should me made dev

per #24 changing status to reviewed and tested by community

In general, it seems like this patch might be against the wrong branch and incorporate a mix of changes made in Drupal 6 and other stuff.

+; Information added by drupal.org packaging script on 2011-02-25
+version = "7.x-1.x-dev"
+core = "7.x"
+project = "talk"
+datestamp = "1298620330"
+
+

That all should be stripped from the patch.

-      $output = '<p>'. t('The talk module gives you the option to display comments on a seperate tab. The option is per content type and can be set in the workflow options of a content type.') .'</p>';
+      $output = '<p>' . t('The talk module gives you the option to display comments on a separate tab. The option is per content type and can be set in the workflow options of a content type. You can control the text that shows in the tab, title, and link to the "talk" page.  You may use tokens in the patterns you set such as [title-raw], [node_comment_count], or [unread_comment_count].') . '</p>';
 

In the future it's best not to make changes like this as part of a port. You should focus the port on just the parts related to making it work on the new version of Drupal.

+  return ( $access = 

Why are you assigning $access this value? Also you have an extra space between "( $"

+  drupal_set_title(check_plain(talk_title($node, 'page')));

In Drupal 7 drupal_set_title already does a check_plain, so this will double encode characters in node titles.

I stopped reviewing at that line as I'm out of time for now.

Thanks, my primary focus was on getting a D7 port working. I'll go back and do some work to cleanup / remove extraneous code.

Thank you so much for your work on this kanani. I'm trying to migrate to D7, and I really like this feature for wikis.

Happy to help chapatt. Did it work ok for you? Any issues?

Subscribing

I've completed the port to Drupal 7. Please report any issues as new issues in the queue, not here. Thanks!

Hi, Where is the link to download the dev version of drupal 7. I would like to try it.

Congratulations on this!

Probably time to remove the #D7CX pledge from the project page :-)