If you have a lot of calls to a service using drupal_http_request(), and that service goes down, then you'll end up with variable_set() running every time that request fails. Instead we should check the value of the current variable before trying to set it again.

CommentFileSizeAuthor
#3 drupal_http_request-D6.patch784 bytescatch
#1 drupal_http_request.patch994 bytescatch
drupal_http_request.patch994 bytescatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new drupal_http_request.patch994 bytes

s/variable_get/variable_set/ for the comment, via beejeebus in irc.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Performance, +Needs backport to D6

D6 patch.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new drupal_http_request-D6.patch784 bytes

hmm, form submissions are playing up for me on d.o today.

damien tournoud’s picture

damien tournoud commented

Well, if that's really a problem, why not doing that directly in variable_set()?

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Closed (duplicate)

It feels like there's the possibility for a race condition in variable_set(), this would also prevent setting variables that are specified in $conf. Either way I'm marking this as a duplicate of #965078: HTTP request checking is unreliable and should be removed in favor of watchdog() calls.