Remove support for template files [#960548]

These are horribly broken, and I cannot see a clear way of fixing the problems with them without entirely changing course. In an effort to get a rock solid base, with only the bare essentials this is one of the things that really needs to get ripped out.

I don't think people are using it in large numbers because otherwise, we would have a slew of bug reports and we don't.

It would be great to add it back at some point, but I think that should entail rethinking what is wanted from the functionality and should be discussed publicly.

Comment	File	Size	Author
#4	960548-templateremove.patch	12.78 KB	vrajak@gmail.com
#1	skinr_960548.patch	8.62 KB	moonray

Comments

Comment #1

moonray commented 8 November 2010 at 20:49

Status:

Active

» Needs review

Status	File	Size
new	skinr_960548.patch	8.62 KB

Here's a patch that removes all template functionality.

Comment #2

vrajak@gmail.com commented 9 November 2010 at 00:59

Status:

Needs work

» Needs review

Patch applies cleanly, and Skinr still seems to work fine. Views seemed alright with some light testing, but I ran into a few issues with Panels, but it might not be skinr related, but rather Panels related since its a dev version. I don't know yet, but I got an error in ctools that prevented me from viewing a panel page after adding custom blocks to it. (system blocks worked fine.)

I would get the following error on trying to view the panel page with the above parameter (custom block in a panel region):

Fatal error: Call to undefined function db_result() in /Users/Vraja/Sites/skinr7/sites/all/modules/ctools/plugins/content_types/block/block.inc on line 110

I don't know if that's a ctools or skinr issue, just putting it out there.

I'm also working on removing the template documentation as per our IRC conversation.

Comment #3

moonray commented 9 November 2010 at 00:09

Status:

Needs review

» Needs work

Comment #4

vrajak@gmail.com commented 9 November 2010 at 00:56

Status	File	Size
new	960548-templateremove.patch	12.78 KB

Okay, here is a patch that removes the "template.html" from /help and modifies the "skinr.help.ini" file accordingly. I did this after moonray's patch above, so it includes all his changes.