Download & Extend

Video import of mp4 does not play (patch included)

Project:FlashVideo
Version:6.x-1.5
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Issue tags:mp4 import patch

Issue Summary

Hi,

Dropping an mp4 file into the video_import directory does generate the necessary object tag needed to play the video

Steps to reproduce:

1. Drop a *.mp4 file into the video_import directory.
2. Click on Run Cron in Drupal's admin panel.
3. A new node for the video will be created for the mp4. However, the video does not show up in the view.

Everything works fine if you were to repeat the process with a *.flv. Everything works fine if you were to rename the *.mp4 file to a *.flv.

I traced the issue to the flashvideo_import() function in flashvideo.module in the following block:

        if ($extension == 'flv') {
          $filemime = 'application/octet-stream';
        }
        else {
          $filemime = 'video';
        }

which should be:

        if ($extension == 'flv' || $extension == 'mp4') {
          $filemime = 'application/octet-stream';
        }
        else {
          $filemime = 'video';
        }

because mp4 files are not transcoded.

Thanks,

Jim

nobody click here