Posted by upupax on November 3, 2010 at 10:30am
6 followers
Jump to:
| Project: | Login Destination |
| Version: | 6.x-2.12 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | setfree |
| Status: | active |
| Issue tags: | conflict, error 301, infinte loop, LoginTobogann, registration |
Issue Summary
With both the modules enabled, I get a 301 infinite loop redirect clicking on the validation link sent by mail after the registration.
This issue started after upgrading from 6.x-2.10 to 6.x-2.12.
Comments
#1
Thank you for the information. This may take a few days for me to troubleshoot. Mean while, please revert back to v2.10.
#2
Do you have any options set for LoginToboggan's redirection section in it's admin?
Also, is "Immediate login" checked?
#3
I don't have "immediate login" checked.
I guess it's something related to login redirection in case of 403 error.
#4
Same config as #3 and reverting to 2.10 did not fix it.
There first thing which comes into my mind is when 403 redirection happens it looses the requested url and therefore can't redirect back to it after login.
So asking logintoboggon module's maintainer to join might be necessary
#5
Hi,
First of all I appreciate all the hard work the maintainers put into this module. However I had chosen another path for me and the sites, where I used this on.
I reverted back to 2.3 and added a patch to get it working perfectly with logintoboggan. However the same patch is also present in 6.x-2.5.
It was a really simple module at that time. It did not do much, but what it did, it did damn good (at least for me in that 6.x-2.5 version). And besides having all in 166 lines and the actual logic even in like 40 lines or so, you could exactly see what it did do.
Yes, it cannot do all the nice stuff this module now does, but it also had overall less issues (in my experience).
I have a proposal for module maintainers doing a complete rewrite the next time:
Make a 3.x branch or so. Let it stabilize, then switch off the old branch.
I think this best practice allows a maximum of error correction and also always lets one see regressions much faster.
Also it allows adding a testsuite. (I am aware that this needs much time)
This is what I do, just as an idea for others, who simply need redirect to some url on login ...
Best Wishes,
Fabian
#6
@Fabianx You are right. The functionality of this module needs to stabilize. It is not a trivial task to redirect after login and the way it is done has changed over time. Even the core implementation has its quirks (#732542: system_goto_action breaks core APIs).
By the way I would love to see this module merged into Login Toboggan, like it was once discussed (#476422: Merging Login Destination). This will help in resolving conflicts.