Might it be possible to configure which versions (or all) of IE that you show the popup to?

CommentFileSizeAuthor
#10 ie6-message.png50.66 KBbetamos

Comments

altrugon’s picture

Yes it would be possible, what do you have in mind for the admin interface to control this?

a_c_m’s picture

Depends how generic you want to go, but assuming it sticks to IE :

Enable popup when
----------------
IE Version : [ Greater than / Less than / Equal to  [\/]]  [ NUMBER INPUT ]

Both could be drop downs.

TapSkill’s picture

This would suggest the module is "NoIE" and not "NoIE6" :)

xamanu’s picture

I would go even further calling it "Browser Exclude" and making it configurable for every type of browser(s).

Anyway noie6 is not really a sustainable name but the whole browser excluding issue could make sense in more use cases than just with ie6, f.e. in these times somebody would like to exclude all browsers that aren't supporting HTML 5 video tags.

a_c_m’s picture

#4 sounds like a good idea to me.

altrugon’s picture

I'm totally ok collaborating in the development of this Browser Filter project, in fact I offer the code of No IE6 as a base and we can build up from there.

The control of the IE family shouldn't be very complicated as is just a matter of changing the conditional with the right version to be excluded, but for the rest of the browsers including those than don't support html5 I would need a hand.

Any volunteers?

xamanu’s picture

We'd have to change from the conditional comments (ie only) to js browser detection with the navigator object and run this against the list defined in the admin ui. The only tricky part i can see is that the config settings have to be given to a simple js-logic which decides if it should block the screen or not.

I'm willing to collab, too.

betamos’s picture

I think #4 is a great idea. I may be interested in volunteering.

However I think it's the developers choice if they want to exclude a browser altogether or just display a notice in the top. Haven't tried this module yet though.

I also wrote a similar module on my previous company, which had a notice up top. I can try to see if I can find the code somewhere...

PM if interested pls

altrugon’s picture

This already crossed my mind when I started to work in the module but I had to set the first milestone somewhere. Now I'm lacking time to do extra development after work, so as I said I'm OK helping with the new module but I can't make it by my self right now.

If we want to make this thing happen we have to star from some point, what about checking how many of us want to work on this and how are we going to call it?

Possible names:

  1. Browser Exclude
  2. Browser Filter
  3. Browser Blocker
  4. Browser Bouncer
  5. Get Out of Here
  6. Dinosaurs are not allowed
betamos’s picture

StatusFileSize
new50.66 KB

@altrugon I really like your name suggestions, I will comment on them later.

I found the module I built a year ago which I talked about earlier. Here is what the warning looks like.

It actually pushes the site down and all styles are !important so they won't get overridden. Colors/border are questionable imo, and I also think the image of the information sign should be removed/replaced.

I'm interested in developing this module, can I get CVS access? It would be awesome.

betamos’s picture

I just found another module (Browser Support) which fits the design that I would prefer for this module. Maybe we should all work on the same project? I may contact the maintainer for that module soon if we'll go with that name.

I think the name should contain the word "Browser". #5 & #6 are awesome names though :)

I like Browser Filter, Browser Support. I also came up with another name, "Browser Policy". What do you think about that?

altrugon’s picture

@Betamos I'm glad that somebody else is pushing this project up. Ok, so regarding to your comments:

  • IE6 doesn't recognize the "!important" clause so we shouldn't use it at all, instead we should use class and id names that have the name of the module in it.
  • It seems to me that Browser Support is an abandoned module. If you check, its recommended releases are for D4 and D5, two version of Drupal that are not longer supported. I would avoid to use this module at all to avoid problems with old code, what also means we shouldn't use its name either.
  • I'm glad that you like #5 and #6 as names (they are my favorites to :P) but your are right, we probably should use something with the word Browser in it.
  • I would suggest to start this module for D7, we have to look forward.

Thank you man and let me know what you think.

betamos’s picture

Okey, great now we got some conversation here :) I'll answer in the same order as you wrote the comments.

  • Really? I didn't know about that. I did a quick search and found that IE6 has an !important bug but it only occurs if you specify the same property twice in the same selector ruleset. Please brief me if I misunderstood anything.
  • Yep that old module seems pretty abandoned. Maybe you're right we should not use that one as it may be confusing.
  • Okey, since Browser Support is taken, we should probably go with Browser Filter or Browser Policy. I think policy sounds better, since it's more like a "way of handling" the different browsers a users may have, and that it may warn the usage, but it may also block a browser totally. Filter may sound confusing (Drupal's text filters) but aside from that I like it. What do you think?
  • Yep, sounds like an awesome idea. Since this module probably won't need larger code modifications for D6, we could probably make a D6 port without too much effort, but D7 goes first, I agree with that.

When we're ready on the name-thingy, we should create a new project I guess. I presume there is no way of renaming this existing project?

betamos’s picture

@altrugon Can you please give me some feedback? I want to get started :)

altrugon’s picture

Sorry man I haven't forgotten about you, it is just that thing are going nuts right now. Here is my feedback:

Name

I think we should name the module Browser Filter, I totally see your point of view for the other option but as a none English speaker I can tell you that most of the people will search for "Browser Filter" than "Browser Policy". The word "filter" is kind of obvious because that is actually when the users are going to do, "select the browsers that are allowed to visit the site".

Pop-up window

The window should be divided in 3 big section: title, body, and browser list, and we just pass variables to an external template, something like this:

browser-filter-popup.tpl.php

  <div id="browser-filter-header"><?php $header; ?></div>
  <div id="browser-filter-body"><?php $body; ?></div>
  <div id="browser-filter-browser-list"><?php $browsers; ?></div>

Administration interface

Over here will have a text field for the header, a text area for the body, and a drag and drop list for the browsers. Sure more options can be added but this is the start point.

Well this is what it comes to my mind right away, what do you think?

stephane bouillet’s picture

Version: 6.x-1.1 » 7.x-2.x-dev
Component: Code » Documentation

Hi,

I've found your module by searching “internet explorer”, and I think you need to have it in the description text of your module, because the main issue is IE (to my mind).
This is maybe the best way to find your module (that I haven't tried yet)

betamos’s picture

Sorry, I've been busy with so many other things, I'll just wanted to let know I'm still interested in this. I will give my feedback as soon as possible.

1kenthomas’s picture

Title: Popup for all IE, not just 6? » Add at least IE7, perhaps all IEs

Seems about time...

altrugon’s picture

Ok I'll try to put some work on this. Needless to say it is going to be only for D7, I don't think we should invest time on the D6 branch when D8 is already in the oven :P

1kenthomas’s picture

I just made it IE 7 as well, via the most obvious method... which was what the client wanted.

altrugon’s picture

Good news Browser Bouncer is out!

I will stop supporting this module since BRB does exactly the same and more.

altrugon’s picture

Status: Active » Closed (works as designed)