There is already an issue open (#956266) for the fatal error, but there are many other problems with ninesixty under D7.

CommentFileSizeAuthor
#16 ninesixty-960968.patch14.35 KBdvessel
#13 960968-ninesisty-d7-update.patch12.3 KBmrfelton
#11 template.php_.patch5.63 KBdanreb
#11 page.tpl_.php_.patch5.22 KBdanreb
#11 ninesixty.info_.patch1.23 KBdanreb
#11 styles.css_.patch473 bytesdanreb
#10 ninesixty.tar_.gz186.51 KBdanreb
#9 ninesixty-960968-d7-fixes.diff10.91 KBskwashd
#7 960968-ninesixty-d7-bugfixes.patch11.14 KBmrfelton
#2 ninesixty-960968-d7b2-fixes-2.diff10.55 KBskwashd
#1 ninesixty-960968-d7b2-fixes.diff10.7 KBskwashd

Comments

skwashd’s picture

skwashd commented
Status: Active » Needs review
StatusFileSize
new ninesixty-960968-d7b2-fixes.diff10.7 KB

I have updated the theme to work a lot better with D7. The attached patch deals with many of the issues I hit when trying to use ninesixty with D7b2. There is possibly more work to be done on this, but it gives someone else a good starting point.

Damn! I wish I had have opened this issue a few seconds earlier and it would be node 960960 :)

skwashd’s picture

skwashd commented
StatusFileSize
new ninesixty-960968-d7b2-fixes-2.diff10.55 KB

Rerolled without version information.

Truncale’s picture

Truncale commented

can you direct me to a link that will show me how to apply this patch?

mrfelton’s picture

mrfelton commented

This fixes a whole load of errors - good going.

skwashd’s picture

skwashd commented

@Truncale try http://drupal.org/patch/apply

@mrfelton Thanks. Is it worthy of a RTBC?

mrfelton’s picture

mrfelton commented
Status: Needs review » Needs work

@skwashd - if this patch is supposed to fix the fatal errors, then I'd say yes. If it's meant to complete the port, then perhaps not.

http://drupal.org/update/theme/6/7#content-region - I don't think we have a specific 'content' region in the theme to place the main page content block.

mrfelton’s picture

mrfelton commented
Status: Needs work » Needs review
StatusFileSize
new 960968-ninesixty-d7-bugfixes.patch11.14 KB

Attached version adds in the content region, and also adds in the title_prefix and title_suffixs vars (http://drupal.org/update/theme/6/7#title-prefix-suffix)

skwashd’s picture

skwashd commented

@mrfelton it wasn't supposed to be a complete port. It was what I had done to get it working for my needs. I will try to review this tomorrow.

skwashd’s picture

skwashd commented
Title: Update code for Drupal 7 beta 2 » Update code for Drupal 7 RC1
StatusFileSize
new ninesixty-960968-d7-fixes.diff10.91 KB

Changes:

* More sane grouping value (based on comment from Shannon Lucas)

* Using group not weight for position - I don't know how it ever worked before

* Fixed regex for framework so subthemes match properly now

* Updates code docs

* Tested on D7RC1

Additions from @mrfelton looked fine

danreb’s picture

danreb commented
Title: Update code for Drupal 7 RC1 » Update code for Drupal 7 RC3
StatusFileSize
new ninesixty.tar_.gz186.51 KB

Attached is my working copy of the NineSixty base theme for RC3, based on the changes and patch above #9 plus some other code changes and updated to work with the D7 RC3

danreb’s picture

danreb commented
StatusFileSize
new styles.css_.patch473 bytes
new ninesixty.info_.patch1.23 KB
new page.tpl_.php_.patch5.22 KB
new template.php_.patch5.63 KB

Here's the patch

dvessel’s picture

dvessel commented

Thank you for all the patches. I will review them and get a new release out shortly.

#1013674: Update status…

mrfelton’s picture

mrfelton commented
StatusFileSize
new 960968-ninesisty-d7-update.patch12.3 KB

Here is patches from 11 rolled up into a more standard drupal patch.

todd nienkerk’s picture

todd nienkerk commented

dvessel: How much of this is now in 7.x-1.x-dev? I have availability to test and commit.

dvessel’s picture

dvessel commented

I've made such a mess of CVS, it took some time to straighten out.

mrfelton, the patch doesn't apply cleanly. Not surprising since I've managed it really poorly but I'll get it fixed manually.

Todd, I'll take care of this. I thought this would be done sooner but I'm trying to better manage the releases by syncing both 6.x and 7.x branches and I was never good with CVS.

dvessel’s picture

dvessel commented
Status: Needs review » Fixed
StatusFileSize
new ninesixty-960968.patch14.35 KB

I committed this patch. I worked based on mrfelton put up here but I changed it so this works exactly like the version 1 release on the 6 branch.

Now that the 6.x and 7.x branches are in sync, I can work towards pushing newer versions out without the complete confusion and utter mess.

v.1.1 will have all the updated styles and templates from the original 960.gs for both versions of core.

Thanks again everyone.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.