With feedback installed, the following message appears instead of a page: Fatal error: Cannot use object of type stdClass as array in /home/mydomain/public_html/myfolder/includes/theme.inc on line 800

I must disable the module for the site to work.

CommentFileSizeAuthor
#3 feedback-HEAD.d7.3.patch6.62 KBsun
#2 feedback-961674.patch7.98 KBpmorel
#1 feedback-961674.patch6.53 KBpmorel

Comments

pmorel’s picture

pmorel commented
Status: Active » Needs review
StatusFileSize
new feedback-961674.patch6.53 KB

Updated a couple of things (I believe due to latest changes in D7 since July):
- change in theme functions argument list (http://drupal.org/node/224333#theme_changes)
- change in drupal behavior (http://drupal.org/node/224333#drupal_behaviors)
- changed hook_block_list function to feedback_block_info
- removed feedback_page_build (otherwise the "[+] feedback" at the bottom will appear twice if the block is enabled)

I've tested the patch with the Drupal 7 beta 2 and everything seems to work as expected (without the patch, I did have the fatal error described above when viewing the admin/reports/feedback page. I also got the issue described in http://drupal.org/node/813970)

pmorel’s picture

pmorel commented
StatusFileSize
new feedback-961674.patch7.98 KB

Forgot one theme_username theme function used when displaying the feedback on the page where the feedback was added (providing the user has the permission to view feedback)
Also, made the message textarea not #required as this was causing a problem if the user submit without entering any feedback.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new feedback-HEAD.d7.3.patch6.62 KB

Some hiccups here and there, but overall, I'm highly super-positively impressed of the work in this issue and the patch. @pmorel: Are you interested in more? :) You may contact the people listed here to learn more. If you are, please follow up in here or contact me via d.o or Skype, thanks!

Thanks for reporting, reviewing, and testing! Committed attached patch to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

--
Unrelated, just FYI:
http://api.drupal.org/api/drupal/includes--common.inc/function/format_us...

--
EDIT: Updated URL to list of people I'm mentoring.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.