At the end of the rsvp_csv_hash_form() function it runs drupal_goto(). The problem is that depending on site / server configuration it may not work correctly and transmit the file to download. Also, strictly speaking it shouldn't work, given that drupal_goto() uses the header() function with a HTTP location path which generally won't want to run after data has been output. Finally, given that the CVS paths are loaded from links from other pages, is there a need to do a redirect at all, why not just let it exit the function normally?

CommentFileSizeAuthor
#2 rsvp-n961858-3.patch493 bytesdamienmckenna
#1 rsvp-n961858.patch482 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new rsvp-n961858.patch482 bytes

Here's a patch that removes the drupal_goto() call so that all downloads will complete correctly and leave visitors at the page they're already viewing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new rsvp-n961858-3.patch493 bytes

As it turns out, without the drupal_goto() it then proceeded to execute return $form; which had the effect of appending a full Drupal page to the CSV data. Here's a patch that simply runs exit() at the end of the function to ensure no additional output is added.