Closed (fixed)
Project:
Provision
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Nov 2010 at 11:37 UTC
Updated:
17 Mar 2012 at 17:50 UTC
Should I submit a patch here or is it possible to merge this commit?
https://github.com/omega8cc/provision/commit/e308ba0238b9125da2472b96fbf...
Comments
Comment #1
omega8cc commentedIssue reported on g.d.o http://groups.drupal.org/node/104004
Comment #2
smoothify commentedThe updated nginx_advanced_include.conf is working fine now - thanks.
However nginx_simple_include.conf is still not working.
The code above doesn't seem to work with the root - if you uncomment the try_files and comment the rest then it does work.
I also have noticed another problem with the @cache declaration. When boost is working it isn't setting the headers correctly.
When using simple config the http headers are:
and when using advanced they are correct:
I'm guessing this is down to the rewrite rule interfering with the add_header command?
Again, when you switch back to the try_files method, it works just fine. Is there a particular reason for using the different approach in the two files?
Comment #3
omega8cc commentedThe "simple" config is to support some older versions of Nginx and is used in Provision by default. We used different Boost compatible configuration before
try_fileswas introduced, and the "simple" config is just a backport of currently used with newer Nginx versions "advanced" config. I don't think we really should support some very old Nginx versions, but at least it should work with any non-Boost enabled site. I will try to rewrite this "simple" config to include there our previously working support for Boost, but I recommend to just use most recent Nginx version with "advanced" config.Comment #4
smoothify commentedI will be using advanced configuration myself from now on, but i noticed the default in aegir is to use the "simple" config - is there a way to change that, or is it best just to use a symlink?
Comment #5
omega8cc commentedWell, we have some test for Nginx version in Provision, so it should do that for you automatically, but for some reason it still doesn't work as expected. Until it is finally fixed, we are using a workaround in Barracuda/Octopus with symlink to override it and use "advanced" config instead.
Comment #6
omega8cc commentedThis has been fixed really long time ago!