Download & Extend
Node Reference Variables » Issues

Doesn't check whether referenced nodes are published

Posted by steveparks on November 5, 2010 at 1:23pm
Project:Node Reference Variables
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:greg.harvey
Status:closed (fixed)

Issue Summary

When nodereference_variables_return_nodes() prepares the referenced nodes it doesn't currently check whether they are published or unpublished. This means that unpublished nodes get included as tabs.

I'm working on a patch and will post it shortly.

Login or register to post comments

Comments

#1

Posted by steveparks on November 7, 2010 at 4:41pm
Status:active» needs review

Initial patch attached

AttachmentSize
nodereference_variables-check_unpublished.patch 1.33 KB

#2

Posted by steveparks on November 7, 2010 at 4:58pm

Corrected patch

AttachmentSize
nodereference_variables-check_unpublished_1.patch 729 bytes

#3

Posted by greg.harvey on November 30, 2010 at 3:46pm
Status:needs review» reviewed & tested by the community

Thanks, Steve. Will apply asap...

#4

Posted by greg.harvey on March 31, 2011 at 10:51am
Assigned to:Anonymous» greg.harvey
Status:reviewed & tested by the community» postponed

Hmm, seems the version of the module this was patched for is quite out of sync with current -dev. I suspect this is my fault and I made improvements on the client project without updating dev (and Steve patched against the client project). I need to merge changes before this patch can be applied.

#5

Posted by thorin_edr on March 27, 2012 at 10:05am
Status:postponed» closed (fixed)

After merging the client version of code, with the improvements made, it seems this is already fixed there, so makes no sense to apply this, as basically there's nothing to apply now =).

Marking as closed (fixed)