Posted by seanberto on November 6, 2010 at 4:54pm
2 followers
Jump to:
| Project: | Boxes |
| Version: | 6.x-1.0-beta11 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Issue Summary
Is this intentional?
See:
<?php
/**
* Theme function for the form.
*/
function theme_boxes_box($block) {
$output = "<div id='boxes-box-" . $block['delta'] . "' class='boxes-box" . (!empty($block['editing']) ? ' boxes-box-editing' : '') . "'>";
$output .= '<div class="boxes-box-content">' . $block['content'] . '</div>';
if (!empty($block['controls'])) {
$output .= '<div class="boxes-box-controls">';
$output .= $block['controls'];
$output .= '</div>';
}
if (!empty($block['editing'])) {
$output .= '<div class="box-editor">' . $block['editing'] . '</div>';
}
$output .= '</div>';
return $output;
}
?>Would it make sense to run $block['delta'] through something like: str_replace('_', '-', $block['delta'])?
Comments
#1
I think at this point there's already so much theming done out there that's dependent on the previous format that we can't change this by flipping underscores to dashes without breaking existing CSS.
In the 7.x version, you can also specify your own custom classes so I don't think it's really an issue there.