Applying to become co-maintainer for Country Icons.

What I will contribute to this module is some preformace enhancements and port this module for D7.

I have working with Drupal almost 2 years and have be an active module developer for 1 year. Have one small module here on Drupal.org Signup Participation but have made some other private modules for customers sites.

Please get back if you have any questions or something else.

Regards,
Christoffer Johansson

CommentFileSizeAuthor
#5 countryicons-d7.zip7.25 KBScyther

Comments

Scyther’s picture

Scyther commented
Title: Applying to become co-maintainer. » Applying to become co-maintainer for Country Icons
Category: task » support
roball’s picture

roball commented

I think it might help to contact Tom directly via his contact form. Would also love to see some progress with this useful module.

Scyther’s picture

Scyther commented

I've used that to contact him. But after 2 weeks and no replay, I'm now trying with this.

mrfelton’s picture

mrfelton commented

Hi,
Sorry for the lack of response - got a lot on my plate right now.

Do you have a working D7 port already Christoffer?

Scyther’s picture

Scyther commented
StatusFileSize
new countryicons-d7.zip7.25 KB

No problems.

Here is a proposal for D7 version, there is some small things to be added and updated, see "@todo" in the code. Note that the all icons are removed in this because of the file size maximun on 1MB.

  • Added static var to countryicons_get_iconsets(...) to enhance the performance of the module when printing out many icons on same page. See comment in function.
  • Use theme('image', ...) in theme_countryicons_icon(...) instead of pure HTML code in this function.
  • Added drupal_strtolower() to act on the "code" variable in theme_countryicons_icon(...) because some modules gives the country code in uppercase letters.

All performance enhancements can also be implemented on the D6 version.

Scyther’s picture

Scyther commented

Any update about this?

roball’s picture

roball commented

Would also love to see some progress here.

Scyther’s picture

Scyther commented

Any update?

mrfelton’s picture

mrfelton commented
Status: Active » Fixed

Hey,
I've added you to the maintainers list. It will be great to see this progress.
Thanks for your time and patience.

- Tom

roball’s picture

roball commented

Great to finally see some progress here!

Scyther’s picture

Scyther commented

Thanks Tom! Will get working on a D6 update and a D7 release.

I don't want to make bigger changes without your approval, so how can we keep in contact in a easy way? You can answer by posting a mail in my contact form if you prefer.

mrfelton’s picture

mrfelton commented

No problem Scyther. I'm really sorry it took me such a long time to get on to this, I've been in my own little micro Drupal climate for the last few months. Things have quietened down a little now, so I should be a little more contactable now! Using my personal contact form is probably the best way to contact me, as that will land in my main inbox.

Thanks,

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.