Comments

dstuart’s picture

Assigned: Unassigned » dstuart

Useful will add it to trunk today

robertdouglass’s picture

Title: Nice to see whoami » Nice to see whoami; bunch of other cleanups
StatusFileSize
new6.19 KB

This should really be 3-4 patches, but I'll stick it here and see if you complain ;-)

Aside from several niggly nitpicks about whitespace, and a tiny typo correction in a description, this patch shuffles some of the variable setting and getting around to make a little clearer distinction between nutch_admin_settings and nutch_admin_crawl. Also, I think that some of the nutch_admin_settings variables were not being set correctly, so that bug is fixed as well.

robertdouglass’s picture

StatusFileSize
new4.84 KB

Ok - I know you're merging things and it's a pain, but until we're on git it's going to be a pain. If you commit what you've got now I'll merge the stuff in from this patch myself.

This is a new improvement (I hope) that streamlines the directory checking for the logs directory. I also had to learn that the is_dir function needs not only the NUCTH/logs dir to be g+wrx, but the NUTCH directory and any shared parents with Apache DOCROOT need g+rx.

So, if my Nutch directory is /home/robert/lib/nutch, here's what stuff has to look like for www-data to be able to do its thing:
/home/robert/Sites/docroot <-- apache docroot
which means:
/home/robert/lib robert:www-data g+rx
/home/robert/lib/nutch robert:www-data g+rx

It wasn't enough that just /home/robert/lib/nutch was writeable with www-data, it needs +x too. Confusing!

robertdouglass’s picture

StatusFileSize
new5.58 KB

Same as above but with one more directory check.

dstuart’s picture

Have commited merged changes up to #2, plus runbot enhancements

robertdouglass’s picture

StatusFileSize
new5.97 KB

I tried to merge my patch with your commits. Review with care, but it seems to be ok. My goals with this patch were to simplify the reporting when directory permissions are not correct. I think it got a little better, but this is still a big sticking point, as it is rather tricky to set the directory permissions in a way that is maximally secure while still actually allowing Drupal to run the process.

dstuart’s picture

StatusFileSize
new3.24 KB

Hey,

Have updated the patch to be inline with trunk.

Regards,

Dave

robertdouglass’s picture

StatusFileSize
new4.08 KB

Here's my current patch against head.
Mostly same as above with two extra lines removed for cleanup (including the line from #971278: drupal_set_message on $process not helpful)

robertdouglass’s picture

StatusFileSize
new4.56 KB

same as above with some whitespace differences.

dstuart’s picture

Status: Needs review » Closed (fixed)

Hi,

Have commited patch to head, thanks Robert

Regards,

Dave